-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Menu rewrite #209
Menu rewrite #209
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing it as we speak.
yeah the example Errors because I forgot to upload the folder. I did that just now so it should work now and you need to merge those into this. |
You guys are real ones |
yes please fix the clippy issues and fmt issues. |
d127490
to
f15c098
Compare
f15c098
to
2d391af
Compare
Ok on second thought the scaling does look stupid it's now fixed |
thank you for all your hard work =D. Also thank you for fixing the scaling XD |
LFG!! |
Fix #196
Complete rewrite of the menu widget
MenuTree
is now divided intoItem
andMenu
, since widgets have to be wrapped inside menu tree nodes and most items won't have a submenu, wrapping withItem
only costs each widget one extra pointerNew helper macros:
menu_item
,menu
,menu_bar
, details are in the docsMenu bar background styling
Mouse interaction is now implemented
Rename
PathHighlight
toDrawPath
, aFakeHovering
variant is added, details are in the docsItemWidth
andItemHeight
are removed, static width and dynamic height should suffice, other options can be easily implemented by the lib usersTodos:
I'm a bit tired working on this rewrite, I'll come back to the todos later, but I need to take break for now
@genusistimelord can you test it and see if there are bugs I didn't catch, if there are't any you can merge it now
Btw I have to comment out this
for some reason cargo won't compile the menu example if I don't