WASM: Create canvas before first window in resumed(). Fixes #2618 #2620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the first window for the compositor. This fixes iced-rs#2618
4 tasks
Mirauzo
reviewed
Oct 3, 2024
| @@ -286,6 +286,77 @@ where | |||
| F: Future<Output = ()>, | |||
| C: Compositor + 'static, | |||
| { | |||
| #[cfg(target_arch = "wasm32")] | |||
| fn resumed(&mut self, event_loop: &winit::event_loop::ActiveEventLoop) { | |||
There was a problem hiding this comment.
**
Suggested change
| fn resumed(&mut self, event_loop: &winit::event_loop::ActiveEventLoop) { | |
| fn resumed(&mut self, event_loop: &winit::event_loop::ActiveEventLoop) { |
**
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a canvas and inserts into the document body, and attaches it to the initial window in Runner::resumed(). This fixes an issue where events were being routed to a WindowId that was not inserted into the window manager as reported in #2618.
With this change, duplicate winit messages to the rogue WindowId are no longer observed, and ModifiersChanged events are associated with the correct WindowId.