Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add warning color to palette #2607

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

DavidAguilo
Copy link

I have added a warning field to the palette since I have found myself needing one. It uses yellow, unless otherwise specified by the theme page.

@DavidAguilo DavidAguilo changed the title Add warning color to palette Feat: Add warning color to palette Sep 25, 2024
Copy link
Contributor

@tvolk131 tvolk131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit of a nitpick, but it might make more sense to have warning be listed between success and danger rather than after danger. Otherwise LGTM!

@DavidAguilo
Copy link
Author

You are right, it makes more sense. I've made the commit to move warning lines to be between success and danger.

Copy link
Contributor

@tvolk131 tvolk131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants