-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add warning color to palette #2607
base: master
Are you sure you want to change the base?
Conversation
…, DARK, DRACULA, NORD and SOLARIZED(both) themes
…one used for diagnostic warnings in the nvim theme
…d with the needed struct and generate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit of a nitpick, but it might make more sense to have warning be listed between success and danger rather than after danger. Otherwise LGTM!
You are right, it makes more sense. I've made the commit to move warning lines to be between success and danger. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
I have added a warning field to the palette since I have found myself needing one. It uses yellow, unless otherwise specified by the theme page.