Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rotation for viewer widget #2467

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Gigas002
Copy link
Contributor

This draft PR is a follow-up from #2334 and #2330, and it introduces a rotation property for viewer widget.
Right now it includes basic stuff and I think it's best behavior is when using together with ContentFit::None, however, all the other ContentFit's are not working as good as this one, and that especially noticable when using Fill (try zooming in/out and changing window sizes when the image is rotated and you'll see).
Would be glad if @DKolter or anyone else could help with further implementation for this :)

@hecrj hecrj modified the milestone: 1.0 Sep 10, 2024
@Gigas002
Copy link
Contributor Author

A post to keep a track on the state of PR, what's working and what's not.
A problem I came up with and can't overcome, is that the rotated image doesn't respect updated layout. This results in incorrect behavior on all content_fit modes, except for none. This is especially noticable when trying to change windows sizes with rotated image on a fill view:

2024-09-30.21-01-58.mp4

I didn't notice other problems, it's the only blocker for this PR to be ready for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants