-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#135: added support for lists in map #146
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where are your tests?
Write at least tests for these scenarios
Adding a |
add docs |
Add this to example/config.yaml
|
Fix/issues
Fixed in next PR |
Feature/#136 empty properties
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please improve error handling when updating from older version. Old Enums show this error
Unhandled exception:
type 'Null' is not a subtype of type 'String'
#0 new YmlGeneratorConfig.<anonymous closure>.<anonymous closure> (package:model_generator/config/yml_generator_config.dart:124:13)
#1 MapBase.forEach (dart:collection/maps.dart:35:13)
#2 new YmlGeneratorConfig.<anonymous closure> (package:model_generator/config/yml_generator_config.dart:115:21)
#3 MapBase.forEach (dart:collection/maps.dart:35:13)
#4 new YmlGeneratorConfig (package:model_generator/config/yml_generator_config.dart:35:17)
#5 ModelGenerator.generate (package:model_generator/main.dart:57:11)
Maybe we should also allow short notations for enums? Gender:
type: enum
values:
MALE: male
FEMALE: femAle
other: other
X: x |
vehicleFull:
json_value: VEHICLE_FULL results in a lowecase jsonValue |
fixes #135