Use AtomicUsize unconditionally for inflight#30
Merged
ibraheemdev merged 1 commit intoibraheemdev:masterfrom May 2, 2025
Merged
Use AtomicUsize unconditionally for inflight#30ibraheemdev merged 1 commit intoibraheemdev:masterfrom
AtomicUsize unconditionally for inflight#30ibraheemdev merged 1 commit intoibraheemdev:masterfrom
Conversation
By reducing the number of buckets by one, we set `MAX_INDEX` to just under `isize::MAX` instead of just under `usize::MAX`. Since it’s extremely unlikely one will have more than `isize::MAX` elements anyway (and is only possible at all in pathological cases like `Vec<()>`), this should not be a real problem for anyone. This allows us to simplify the code, using `fetch_add` on all platforms, as now we can more easily check for overflows with the simple assumption that there won’t be `isize::MAX` concurrent threads pushing to the vector.
ibraheemdev
reviewed
Apr 30, 2025
Owner
|
Looks good, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By reducing the number of buckets by one, we set
MAX_INDEXto just underisize::MAXinstead of just underusize::MAX. Since it’s extremely unlikely one will have more thanisize::MAXelements anyway (and is only possible at all in pathological cases likeVec<()>), this should not be a real problem for anyone. This allows us to simplify the code, usingfetch_addon all platforms, as now we can more easily check for overflows with the simple assumption that there won’t beisize::MAXconcurrent threads pushing to the vector.