Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger smoke test build after SDK is built #261

Draft
wants to merge 1 commit into
base: ibm
Choose a base branch
from

Conversation

llxia
Copy link

@llxia llxia commented Dec 17, 2024

Copy link

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

@llxia
Copy link
Author

llxia commented Dec 17, 2024

Ideally, smoke test, sign_build, and create_installer_xxx should all run in parallel. We will need to communicate to Adoptium for the workflow change. For now, trigger the smoke test build after SDK is built, so it will not be blocked.

Moving forward, we will have Semeru-specific smoke tests added, and the smoke test builds are required to pass.

@llxia llxia requested a review from AdamBrousseau December 17, 2024 15:33
@AdamBrousseau AdamBrousseau marked this pull request as draft December 17, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant