Implement bigquery auth using pydata_google_auth #1728
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tswast Can you review this when you get a chance? |
cpcloud
commented
Mar 14, 2019
tswast
approved these changes
Mar 14, 2019
There was a problem hiding this comment.
Auth changes LGTM.
You could potentially allow passing in additional scopes in case folks want to do federated queries to Google Sheets, but they can always call pydata_google_auth themselves and pass in the scopes they need in that case. I think defaulting to just the BigQuery scope is the right choice.
|
Looking at this, I'm realizing I should pull some of the auth how-to stuff from pandas-gbq over to the pydata-google-auth docs so that it can be a central resource for Ibis and pandas to link to. I've filed pydata/pydata-google-auth#19 to track that. I can follow-up with a PR to the Ibis docs once I get that in place. |
tswast
requested changes
Mar 14, 2019
tswast
approved these changes
Mar 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also allow project_id and dataset_id to be optional
Closes #1583