Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(geometry): make output handling robust to text or bytes #10478

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Nov 12, 2024

Fixes some issues discovered while attempting to address #10209. Will expand with more detail later today.

@cpcloud cpcloud added this to the 10.0 milestone Nov 12, 2024
@cpcloud cpcloud added geospatial Geospatial related functionality bigquery The BigQuery backend duckdb The DuckDB backend labels Nov 12, 2024
@github-actions github-actions bot added tests Issues or PRs related to tests sql Backends that generate SQL labels Nov 12, 2024
@cpcloud
Copy link
Member Author

cpcloud commented Nov 12, 2024

BigQuery is passing:

cloud in 🌐 falcon in …/ibis on  bq-geom is 📦 v9.5.0 via 🐍 v3.12.7 via ❄️  impure (ibis-3.12-env)
❯ pytest -m bigquery -n auto --dist loadgroup --snapshot-update -q
bringing up nodes...
.xxxxxxxxx.xxxxxxxxxxxxxxxxxxxxxxxxxx.xxxxxxxxxxxxx.xxxxxxxxxxxxxxxxxxx.xxxxxx.xxxxxx.xxxxxxxxx.xxxxxxxxxxxx.xxxsssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssxxx.xx.........xxxxxx.x......xx.x......xx...x.....x....s........x.........s............x...x..............x......s...................................x...........xxx..x..x........ [ 17%]
sssssssssssssssss.ssss..x....x.......x....................x......x.......xx......x...........x....................................................x.........x....x........x.........x.....x.............x....x...x......x.........xxx.x..................xx..........x...........x.................x.xx.............x.....x..x..x.xxx....x......x.....x...x.........xx................x.x.......x.x.x [ 34%]
xx..........................sx...xxx.x.s.........x.x......s...x....x....x...x.x..........s............x....x.......x.xxxx..x.......x............x........x..xx......x.x.......x.x...x......x.x..x....xxx......x.x.xx........x....xx...x.......xxx.........x..x...........x...x.x....x.xxx.x....xxx.x..xx..xxx..xxx...xx..x.x.xxxxxx.x.x.x.......xx..xx.........xxx..xx......x.......x.....x.......... [ 51%]
..x.............................xx.........................................................x...............x................x.......s..............x..........x............xx.x...x..x..x....x...x.xx..x................xxX......x....x.........x...xx......x.x....x.x.xXx......X..x...x..X..x.x...x..x...x...xx..xx......x.x..............xx..x.......x.x..................x....................xx.. [ 68%]
....................x.....xx..x........x.xx.......x............x.....x...............................x............x.........x.x.....x.......x.x........x.......xx.....x.............xs......xx...........s.......s....s.................................x........................................x.......x................................................x.......................................... [ 86%]
.....x.................................................................x......................................................................................................................................x.........................................x.................................................................                                                                            [100%]
1762 passed, 132 skipped, 361 xfailed, 4 xpassed in 247.51s (0:04:07)

@cpcloud cpcloud force-pushed the bq-geom branch 4 times, most recently from 07c1812 to 0fafd59 Compare November 12, 2024 17:28
@cpcloud cpcloud merged commit 49b404a into ibis-project:main Nov 13, 2024
75 checks passed
@cpcloud cpcloud deleted the bq-geom branch November 13, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bigquery The BigQuery backend duckdb The DuckDB backend geospatial Geospatial related functionality sql Backends that generate SQL tests Issues or PRs related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant