Open
Conversation
| if (graphHopperResponseFile) { | ||
| nock('https://graphhopper.com') | ||
| // Turn on log in order to view nock request URLs. | ||
| .log(console.log) |
Contributor
Author
There was a problem hiding this comment.
nock.log no longer exists in recent node versions.
| "mastarm": "^5.3.1", | ||
| "md5-file": "^4.0.0", | ||
| "nock": "^9.0.14", | ||
| "nock": "^13.5.6", |
Contributor
Author
There was a problem hiding this comment.
Nock 14+ require adding other mocks that are currently missing. Lmk is that's worth it in this PR.
Contributor
Author
|
Build passes!! 🎉🎉🎉 |
2 tasks
miles-grant-ibigroup
requested changes
Jan 20, 2026
Contributor
miles-grant-ibigroup
left a comment
miles-grant-ibigroup
left a comment
There was a problem hiding this comment.
Thanks for this work! I'm very excited to see this working.
However, I'm getting a lot of this error!
when using the new yarn commands...
✘ [ERROR] The JSX syntax extension is not currently enabled
lib/manager/components/validation/MobilityDataValidationResult.js:22:9:
22 │ return <Table bordered className='table-fixed' fill hover stripe...
╵ ^
The esbuild loader for this file is currently set to "js" but it must be set to "jsx" to be able to parse JSX syntax. You can use "loader: { '.js': 'jsx' }" to do that.
| @@ -1,5 +1,5 @@ | |||
| # syntax=docker/dockerfile:1 | |||
| FROM public.ecr.aws/s2a5w2n9/puppeteer:latest | |||
Contributor
There was a problem hiding this comment.
Very happy about this!
Contributor
Author
miles-grant-ibigroup
approved these changes
Feb 2, 2026
Contributor
miles-grant-ibigroup
left a comment
miles-grant-ibigroup
left a comment
There was a problem hiding this comment.
Code all looks good, things work well running offline, I haven't tested deployment yet but I'm excited to see that things work with the latest version of node
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
devbefore they can be merged tomaster)Description
This PR replaces mastarm with Vite as the build system (for dev and production). Other parts involving mastarm remain unchanged.
mastarm buildormastarm deployUseful commands:
env YAML_CONFIG=<path-to-frontend>/env.yml yarn startenv YAML_CONFIG=<path-to-frontend>/env.yml yarn build