Additional feed summary params by br648 · Pull Request #634 · ibi-group/datatools-server

br648 · 2025-09-24T15:26:31Z

Checklist

Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
The description lists all applicable issues this PR seeks to resolve
The description lists any configuration setting(s) that differ from the default settings
All tests and CI builds passing

Description

Update to provide additional parameters to the UI via feed summary. This now contains two new parameters:

latestSentToExternalPublisher
publishState (enum)

In order to get Gtfs plus validation into feed version, validation now takes places (via ValidateGtfsPlusFeedJob) in the same places as mobility data validation. This only happens with new feed versions and is not backwards compatiable, therefore gtfs plus validation won't be available for older feed versions.

…lidation and save to feed versi

…ed version and tests

src/main/java/com/conveyal/datatools/manager/models/FeedSourceSummary.java

… feed version

…-fields

…d namespace

…-fields

…includes error counts using exp

…sionSummary and created separat

…t if published feed version not

…ate to process all returned doc

…ion for feed sources Added sort

… obtain feed source error count

…SourceSummary

binh-dam-ibigroup

A few comments for now, but I sense that we will need to compute the publish status in datatools-server rather than the UI.

src/main/java/com/conveyal/datatools/manager/controllers/api/GtfsPlusController.java

src/main/java/com/conveyal/datatools/manager/gtfsplus/GtfsPlusValidation.java

src/main/java/com/conveyal/datatools/manager/jobs/ValidateGtfsPlusFeedJob.java

src/main/java/com/conveyal/datatools/manager/models/FeedVersion.java

src/main/java/com/conveyal/datatools/manager/models/FeedVersionSummary.java

src/main/resources/mongo/getFeedSourceSummaries.js

…exclude editor namespaces from

…tes): Data sanitizer updates sh

…-fields

Newer reference is no longer needed

binh-dam-ibigroup

Nice changes, they work. A few more minor changes, but happy to pass this.

src/main/java/com/conveyal/datatools/manager/gtfsplus/GtfsPlusValidation.java

src/main/java/com/conveyal/datatools/manager/models/FeedSourceSummary.java

src/test/java/com/conveyal/datatools/manager/controllers/api/FeedSourceControllerTest.java

src/main/java/com/conveyal/datatools/manager/models/PublishState.java

…-fields

JymDyerIBI

👍 Whew! A lot of stuff, it looks good.

src/main/java/com/conveyal/datatools/manager/models/FeedSourceSummary.java

binh-dam-ibigroup

I found a discrepancy while testing the UI, in some cases the earliest version of a feed is returned instead of the latest.

wolli · 2026-01-06T05:43:29Z

Danke für den Hinweis.
LG

…ion from latest deployment

…d validation summary is need to

…t available

binh-dam-ibigroup

Seems to work now, thanks for the changes. Consider incorporating the indicated suggestions.

src/main/java/com/conveyal/datatools/manager/gtfsplus/GtfsPlusValidation.java

src/main/java/com/conveyal/datatools/manager/models/FeedVersionSummary.java

JymDyerIBI

Updates also look good.

Two approvals already.

br648 added 4 commits September 24, 2025 16:24

feat(Additional feed summary params):

a82bed7

improvement(Update to include gtfs plus validation): Gen gtfs plus va…

af7ec62

…lidation and save to feed versi

improvement(Store gtfs plus validation in feed version): Update to fe…

075cdc7

…ed version and tests

improvement(Updates param name): Name is more inline with usage

a9fb58d

br648 assigned josh-willis-arcadis Oct 10, 2025

josh-willis-arcadis previously requested changes Oct 14, 2025

View reviewed changes

src/main/java/com/conveyal/datatools/manager/models/FeedSourceSummary.java Show resolved Hide resolved

josh-willis-arcadis assigned br648 and unassigned josh-willis-arcadis Oct 14, 2025

br648 added 6 commits October 15, 2025 15:45

improvement(Updated feed source summary): Added published version id

a1a056f

improvement(GtfsPlusController): Update to save validation to related…

7a5ce48

… feed version

improvement(maven.yml): Bumped node version from 20.x to 22.x

43756e8

Merge branch 'dev' into feature/DT-530-additional-feed-source-summary…

dde3bc4

…-fields

improvement(Added new params): Now includes published feed version an…

fcdbd93

…d namespace

Merge branch 'dev' into feature/DT-530-additional-feed-source-summary…

21c3b53

…-fields

br648 mentioned this pull request Nov 11, 2025

Expose DB call to obtain feed version error counts ibi-group/gtfs-lib#20

Closed

4 tasks

br648 added 3 commits November 11, 2025 16:37

improvement(Update to include error counts): Feed source summary now …

fed3371

…includes error counts using exp

improvement(Code refactor): Move feed version extraction into FeedVer…

a437f5d

…sionSummary and created separat

improvement(FeedSourceSummary): Update to mongo query to return resul…

50455b9

…t if published feed version not

josh-willis-arcadis mentioned this pull request Nov 13, 2025

Display Feed Publish Status on List of Feeds ibi-group/datatools-ui#1044

Merged

7 tasks

br648 added 4 commits November 18, 2025 13:03

improvement(Addressed bug with extracting feed source summaries): Upd…

e02a53f

…ate to process all returned doc

improvement(FeedSourceSummary): Updated query to get latest feed vers…

70eef64

…ion for feed sources Added sort

improvement(Feed source error count retrieval): New separate class to…

2b6cc83

… obtain feed source error count

improvement(Fixed merge conflicts): Addressed conflicts in class Feed…

308de2f

…SourceSummary

br648 assigned binh-dam-ibigroup and unassigned br648 Dec 10, 2025

binh-dam-ibigroup reviewed Dec 10, 2025

View reviewed changes

br648 added 4 commits December 11, 2025 08:21

feat(Exclude editor schemas from deletion): Data sanitizer update to …

ec3a329

…exclude editor namespaces from

improvement(Restored to previous commit to remove data sanitizer upda…

0572b6a

…tes): Data sanitizer updates sh

Merge branch 'dev' into feature/DT-530-additional-feed-source-summary…

3ea77c1

…-fields

improvement(Refactor to provide publish state and address PR feedback):

4310c1b

improvement(pom.xml): Restored gtfs-lib library reference

cb06d5f

Newer reference is no longer needed

binh-dam-ibigroup approved these changes Dec 16, 2025

View reviewed changes

binh-dam-ibigroup assigned br648 and unassigned binh-dam-ibigroup Dec 16, 2025

josh-willis-arcadis reviewed Dec 16, 2025

View reviewed changes

src/main/java/com/conveyal/datatools/manager/models/PublishState.java Outdated Show resolved Hide resolved

br648 added 2 commits December 17, 2025 09:45

Merge branch 'dev' into feature/DT-530-additional-feed-source-summary…

259d4c3

…-fields

improvement(Addressed PR feedback):

ac2f2c7

br648 assigned JymDyerIBI and unassigned br648 Dec 17, 2025

JymDyerIBI approved these changes Dec 18, 2025

View reviewed changes

br648 added the Awaiting UI update being merging label Dec 18, 2025

br648 requested a review from josh-willis-arcadis December 18, 2025 08:42

binh-dam-ibigroup reviewed Jan 6, 2026

View reviewed changes

src/main/java/com/conveyal/datatools/manager/models/FeedSourceSummary.java Outdated Show resolved Hide resolved

binh-dam-ibigroup requested changes Jan 6, 2026

View reviewed changes

binh-dam-ibigroup assigned br648 and unassigned JymDyerIBI Jan 6, 2026

improvement(Return correct feed version): Return the latest feed vers…

3f55124

…ion from latest deployment

br648 requested a review from binh-dam-ibigroup January 14, 2026 08:01

br648 added 2 commits January 14, 2026 11:19

revert(Reinstated feed source published validation summary): Publishe…

d7b43ae

…d validation summary is need to

fix(Update to guard against NPE): error count will be set to -1 if no…

c37a33a

…t available

binh-dam-ibigroup approved these changes Jan 26, 2026

View reviewed changes

improvement(Addressed PR feedback): Removed redundant null checks.

f1b8d77

JymDyerIBI approved these changes Jan 27, 2026

View reviewed changes

br648 removed the Awaiting UI update being merging label Jan 29, 2026

br648 merged commit 4ed3bb8 into dev Jan 29, 2026
6 checks passed

Conversation

br648 commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Description

Uh oh!

Uh oh!

binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JymDyerIBI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

Uh oh!

wolli commented Jan 6, 2026

Uh oh!

binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JymDyerIBI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

br648 commented Sep 24, 2025 •

edited

Loading