IBX-11029: Fixed tests #1790
IBX-11029: Fixed tests #1790
Conversation
OstafinL
force-pushed
the
IBX-11029-Fixed-tests
branch
from
fc74261 to
5e334b3
Compare
…. Adjusted related test coverage.
tbialcz
force-pushed
the
IBX-11029-Fixed-tests
branch
from
b38adf9 to
2840c90
Compare
ibexa-workflow-automation-1
bot
requested review from
GrabowskiM,
RopRaptor,
Steveb-p,
ViniTou,
adamwojs,
albozek,
alekmick,
alongosz,
barw4,
ciastektk,
dew326,
konradoboza,
mikadamczyk,
tbialcz,
tischsoic and
wiewiurdp
and removed request for
a team
ViniTou
left a comment
ViniTou
left a comment
There was a problem hiding this comment.
guess we can use numeric-string instead of string in those cases
Yes, I can switch to numeric-string, but PHPStan will still warn because numeric-string is always a string — so is_string() is seen as redundant. |
| new FormErrorDataTestWrapper( | ||
| 'The selected choice is invalid.', | ||
| ['{{ value }}' => 'foo'], | ||
| 'children[limitation_type]' | ||
| ), |
There was a problem hiding this comment.
That codifies duplicate validation instead of addressing it. If the form only needs one message, this change will hide a regression and could show users two identical errors. But maybe it is not the case at all. What about changing the message in the second form error?
There was a problem hiding this comment.
I checked it — error_bubbling => false doesn’t change anything. Symfony 7.3 now produces two errors for expanded choice fields, so the duplication is expected.
… expectations in all relevant data transformers and tests for improved clarity.
|
10 participants
Description:
For QA:
Documentation: