IBX-9838: FIX Edit option in three-dot menu remains clickable despite insufficient user permissions #1525
+14
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konradoboza
reviewed
Apr 15, 2025
|
konradoboza
approved these changes
Apr 15, 2025
tbialcz
approved these changes
Apr 16, 2025
mikadamczyk
reviewed
Apr 16, 2025
| @@ -226,7 +226,7 @@ private function getLocationPermissionRestrictions(Location $location): array | |||
| 'restrictedLanguageCodes' => $createLimitationsValues[Limitation::LANGUAGE], | |||
| ], | |||
| 'edit' => [ | |||
| 'hasAccess' => $lookupUpdateLimitationsResult->hasAccess(), | |||
There was a problem hiding this comment.
Have you checked other uses of this method? If it does not work correctly, it should be fixed, or all usage should be replaced.
There was a problem hiding this comment.
I need to investigate this one, we have another variable lookupUpdateLimitationsResult thats also not working correctly here, I will come back here once I have done some test.
| return $this->permissionResolver->canUser( | ||
| 'content', | ||
| 'edit', | ||
| $content |
There was a problem hiding this comment.
Don't we need to pass any targets here as a fourth argument?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
As stated in the public ticket, when the user has a limitation, for example, only for a specific content type, lets say
Article, if we go to the Content tree, click on any other content type and open the context menu, the edit button would be clickable and it would throw a permission error.I'm fixing here the edit check to rely on
this->permissionResolver->canUserinstead ofhasAccessmethod.