-
Notifications
You must be signed in to change notification settings - Fork 19
IBX-3456 Collapse all button support #1394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| @@ -0,0 +1,37 @@ | |||
| .ibexa-multi-collapse { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved styles from product-catalog. Based on previous review comment let me know if I still should change class name to ibexa-pc-...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if those styles are moved from PC where will be a base twig template for a multi-collapse feature?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed: There is no base twig template due to its too general purpose
1228b09 to
c8db495
Compare
baed467 to
349a81f
Compare
...bundle/Resources/views/themes/admin/ui/component/collapse_all_btn/collapse_all_btn.html.twig
Outdated
Show resolved
Hide resolved
KamilSznajdrowicz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bozatko please resolve the conflicts, I can't proceed with the rebase.
3e31c41 to
300f6d2
Compare
|
KamilSznajdrowicz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA Approved on commerce 4.6.x-dev
Regression with improved behat tests: ibexa/commerce#1172



Related PRs:
Description:
For QA:
Documentation: