Add exceptions rates support#61
Add exceptions rates support#61trippo wants to merge 10 commits intoibericode:mainfrom trippo:master
Conversation
|
Hi @trippo I would recommend to split the PR, you're trying to do 2 things here:
The second one is a breaking change |
|
Re-added GB validator |
|
@VincentLanglet please review |
I'm not the maintainer, I cannot
|
src/Countries.php
Outdated
| 'VI' => 'Virgin Islands, U.S.', | ||
| 'WF' => 'Wallis And Futuna', | ||
| 'EH' => 'Western Sahara', | ||
| 'XI' => 'Northern Ireland', |
There was a problem hiding this comment.
Xi is not a valid IsoCode cf https://en.wikipedia.org/wiki/List_of_ISO_3166_country_codes
It's only used for VAT but it's not an isocode.
src/Countries.php
Outdated
| public function isCountryCodeInEU(string $code) : bool | ||
| { | ||
| $eu = ['AT', 'BE', 'BG', 'CY', 'CZ', 'DE', 'DK', 'EE', 'ES', 'FI', 'FR', 'GB', 'GR', 'HU', 'HR', 'IE', 'IT', 'LT', 'LU', 'LV', 'MT', 'NL', 'PL', 'PT', 'RO', 'SE', 'SI', 'SK']; | ||
| $eu = ['AT', 'BE', 'BG', 'CY', 'CZ', 'DE', 'DK', 'EE', 'ES', 'FI', 'FR', 'GR', 'HU', 'HR', 'IE', 'IT', 'LT', 'LU', 'LV', 'MT', 'NL', 'PL', 'PT', 'RO', 'SE', 'SI', 'SK', 'XI']; |
There was a problem hiding this comment.
Same, XI is not a valid isocode
|
Hello @trippo, I'm the maintainer yet I wholeheartedly agree with @VincentLanglet - unfortunately there are so many changes in this PR targeting several separate things that it's really hard for me to confirm what is changing and whether this is safe to merge in the codebase. Separate PR's would be super helpful in making this a little easier for me. |
dannyvankooten
force-pushed
the
master
branch
from
2e14811 to
5d04808
Compare
3 participants
No description provided.