-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revive window grab space shifting #1698
Conversation
If anyone wants to try it. |
Just tried it on Seqoia 15.0.1 (24A348) and it moves the cursor, but the window isn't moved. |
You need to set the system shortcuts for traversing spaces. This piggybacks on top of them. |
Ah, the code assumes they use ctrl and not option for the modifier there. It was not particularly robust, which is why I went the private api route. |
@kjendrzyca this build should detect it automatically. Amethyst.zip |
And another build that shouldn't need the user to manually enable them. |
Now I just need to test this with multiple screens. |
Works quite well between spaces 1-4 (does not work to move windows You did it! Thanks a lot. macOS Monterey 12.7.6 Edit: |
This build (21.2 (116)) still doesn't work for me. It works partly on the internal display but not on external displays. Sometimes throwing to a different space will throw the window to a different display (not consistently though) but most often the window will just flicker and remain on the same space on the same display. To be more specific.
Can I do anything for you to help diagnose? I'm on macOS Sequoia 15.1.1 (24B91), M2 max chip. |
Yeah, it's broken on multiple displays because of the order of operations. I have a fix for that, but it still needs a bit of testing. |
Works great on 15.0.1 (24A348) now, thank you! The only issue I'm seeing is that smaller floating windows like Amethyst preferences flicker when throwing. But that's not an issue at all. |
If a full-screen window is placed anywhere other than at the end of the space list, the transition destination when the window is thrown to the left or right seems to be incorrect. 1 [2] F 3 4 5 6 7 8 9 If you move twice to the right here, it moves to 5 for some reason. 1 2 F 3 4 [5] 6 7 8 9 If I try to move one more time to the left, it does not move. 1 2 F 3 4 [5] 6 7 8 9 My environment is single display. |
I think I got multiple displays working correctly, and I fixed the issue with throwing left and right in the presence of full screen windows. |
Full-screen windows can now be successfully moved left or right, even if the full-screen window is in the middle of a space list. |
Tried this out. It fixed the issue with my web browser windows (Firefox) and terminal windows. For some reason, Visual Studio code (1.95.3) had some issue where after throwing a window to a new space, Amethyst was not recognizing the window as part of that space and not updating the layout. Even if I changed the layout (from fullscreen to tall for example), the window that was thrown is not recognized as part of that space and can't be focused with keyboard shortcuts. This would resolve if after throwing the window, I switched spaces and then back to the space again. As another note, I tried disabling "Follow thrown windows between spaces" and noticed a strange behavior where my focus DID follow the window, but then would automatically switch back to my previous work space. I'm wondering if there is a conflict with my keyboard shortcuts between amethyst and mission control. |
Despite not being in fullscreen mode. Unchecking this option in VS Code resolved my issue!
I am seeing similar issues about windows not being recognized. I don't have those apps to test, but VS Code allowing me to toggle that setting and resolving the issue seems promising. If there was a way to switch full screen mode at the system level to use "zoom" mode instead, I wonder if there would be less apps with issues. All though, worth noting that on my machine Firefox uses "Full screen mode" and works with throwing between spaces Test Cases:
Doesn't Work
Notably Works
Notably doesn't work
|
@SeaButts thank you for the thorough report! |
Thanks for your work on this and tackling the new OSX changes. Since the main apps I manage work with this build, the bulk of my workflow is actually resolved with this version! Here are my settings in case anything else sticks out.
|
Made some changes that I think address the issues with some applications—I tested with Chrome and VS Code. I think it's the difference between a native title bar and a custom one. That was the difference with that option in VS Code. |
* development: Revive window grab space shifting (#1698) Amethyst 0.21.2 (#1652) Update README.md with workspaces-auto-swoosh suggestion (#1664) Apply yabai's fix for moving windows between spaces in macOS 12, 13, and 15 (#1677) Apply yabai's fix for moving windows between spaces in macOS 14.5 (#1648) Add new option to sample config (#1642) Amethyst 0.21.0 (#1606) Support a fifth screen (#1627) Remove RubyGems (#1611) Replace `xcpretty` with `xcbeautify` (#1609) Correct typos on sample config file (#1610) Further attempts to fix space moving focus loss (#1591) Remove the old icon file (#1594) Sort json keys for custom layout ids (#1592) Clarify window margin behavior (#1589) Update the correct name for a layout in config sample (#1587) Only perform raise ax action when focusing (#1586) Add preference to hide menu bar icon (#1583) Improved Clarity for Accessibility API Permission Instructions (#1575)
No description provided.