-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support a fifth screen #1627
Support a fifth screen #1627
Conversation
I'm not sure if I covered all the ground. I tried to test build it locally, but I got an error |
@@ -62,6 +62,10 @@ | |||
"mod": "mod1", | |||
"key": "q" | |||
}, | |||
"focus-screen-5": { | |||
"mod": "mod1", | |||
"key": "g" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just assigned a random new key that I see has not been assigned to any other action yet.
@@ -17,7 +17,7 @@ class HotKeyManagerTests: QuickSpec { | |||
it("has the right number of screens") { | |||
let keyMapping = HotKeyManager<SIApplication>.hotKeyNameToDefaultsKey() | |||
let screenCommands = keyMapping.filter { $0[1].hasPrefix(CommandKey.focusScreenPrefix.rawValue) } | |||
expect(screenCommands.count).to(equal(6)) | |||
expect(screenCommands.count).to(equal(7)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this is the right change (can't run tests locally due to build failure) though it seemed relevant.
OK, I figured out that the build was failing because it was trying to invoke I wonder if the version of the SDK used to build the app is too new or something. |
Thanks! It seems that the test pipeline cannot be run at the moment. Maybe it's the case for all PRs?
|
I think that problem is unrelated, so I'll merge and deal with the build later. |
Thanks @ianyh ! I see this is scheduled for the 0.22 release. I was able to build the app locally and it works as expected. Finally able to use Amethyst with 5 screens at the same time : ) (BTW it took me a while to figure out that I'd need to run |
* development: Update README.md with workspaces-auto-swoosh suggestion (#1664) Apply yabai's fix for moving windows between spaces in macOS 12, 13, and 15 (#1677) Apply yabai's fix for moving windows between spaces in macOS 14.5 (#1648) Add new option to sample config (#1642) Amethyst 0.21.0 (#1606) Support a fifth screen (#1627) Remove RubyGems (#1611) Replace `xcpretty` with `xcbeautify` (#1609) Correct typos on sample config file (#1610)
* development: Revive window grab space shifting (#1698) Amethyst 0.21.2 (#1652) Update README.md with workspaces-auto-swoosh suggestion (#1664) Apply yabai's fix for moving windows between spaces in macOS 12, 13, and 15 (#1677) Apply yabai's fix for moving windows between spaces in macOS 14.5 (#1648) Add new option to sample config (#1642) Amethyst 0.21.0 (#1606) Support a fifth screen (#1627) Remove RubyGems (#1611) Replace `xcpretty` with `xcbeautify` (#1609) Correct typos on sample config file (#1610) Further attempts to fix space moving focus loss (#1591) Remove the old icon file (#1594) Sort json keys for custom layout ids (#1592) Clarify window margin behavior (#1589) Update the correct name for a layout in config sample (#1587) Only perform raise ax action when focusing (#1586) Add preference to hide menu bar icon (#1583) Improved Clarity for Accessibility API Permission Instructions (#1575)
As mentioned in #1584, MacOS now supports up to 5 displays. This PR adds support for interacting with a fifth screen.