Prevented propagation when DropdownMenu is present in Table
#2341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smmr-dn
requested review from
mayank99 and
r100-stack
and removed request for
a team
mayank99
approved these changes
Nov 14, 2024
r100-stack
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
According to @r100-stack's comment in #2337,
DropdownMenumight propagate up to the main row which toggles row selection state. Currently, the proposed solution in this PR is to temporarily prevent propagation in theTablestories by usinge.stopPropagation()in theonClickevent handlers. This approach is a temporary measure until a more permanent solution can be implemented within the internal component code.Testing
Confirmed that clicking row action items (such as "Edit" or "Delete") does not trigger single row selection.
table-row-action-before.mp4
table-row-action-after.mp4
Docs
N/A