Updated documentation for Typography #2324
Conversation
… uyen/flex-doc
… uyen/tree-doc
… uyen/tree-doc
smmr-dn
requested review from
mayank99 and
r100-stack
and removed request for
a team
examples/Label.inline.jsx
Outdated
There was a problem hiding this comment.
I think this example can be similar to the Label inline react story. Because, Flex further adds its gap.
Also, since this example is shown next to the list of display styles, I think we have to show an example of "block" too. The file can be renamed accordingly.
There was a problem hiding this comment.
Since the "block" style is default which is shown in the main example. Should I move it down?
There was a problem hiding this comment.
Not sure what you meant by "move it down". But what I meant to say was that this example can also include a label + input pair with "block" to show the difference between block and inline.
There was a problem hiding this comment.
Oh what I meant was to move the main example down to the Display styles section. I created a LabelSelect so that users can switch between the two layouts.
There was a problem hiding this comment.
Instead of switching between the two, I think we can have two separate Label + Input pairs within the same example, one "block" and the other "inline". That way users can see both simultaneously.
There was a problem hiding this comment.
I have combined two labels into one.
Changes
Updated existed documentation for Typography.
Testing
N/A
Docs
N/A
After-PR TODO:
Labelinto another doc page and rearrangeTypographydoc (Updated documentation for Typography #2324 (comment))