useWarningLogger
only runs on the client
#2251
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
An example from
examples
was failing on the Astro docs site:This is because
useWarningLogger
useswindow
(not available on the server), but in Astro, that component was running on the server.iTwinUI/packages/itwinui-react/src/utils/hooks/useWarningLogger.ts
Line 47 in e4c1673
So, this PR uses
getWindow()
instead ofwindow
.getWindow()
returnsundefined
whenwindow
does not exist instead of giving an error.iTwinUI/packages/itwinui-react/src/utils/functions/dom.ts
Lines 14 to 20 in e4c1673
Testing
IconButton is missing the ``label`` prop.
warning) are still working.Docs
No changeset needed imo as not a significant change for the user.