-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add veracode scan #2250
Add veracode scan #2250
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thanks for creating this PR. It generally looks ok but I'm wondering if we can reduce maintenance burden.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small suggestions
Co-authored-by: Mayank <[email protected]>
I see your audit has been failing for some time, do you want me to fix these? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks again for creating this PR
We are aware of the audit
issue, don't worry about that. I believe we were waiting for a fix from one of our dependencies; it might be a good time to check again. /cc @r100-stack
Yes, I'm looking at that from time to time. Looks like |
Changes
Add Veracode static code analysis. Gather, zip, and upload files to Veracode for analysis.
Testing
Tested zipping locally. Tested zip and upload in CI and validated in Veracode dashboard.