New OverflowContainer wrapper around useOverflow
#2152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Temporarily remove unnecessary CI jobs.
r100-stack
requested review from
mayank99 and
Ben-Pusey-Bentley
and removed request for
a team
mayank99
reviewed
Jul 19, 2024
packages/itwinui-react/src/utils/components/OverflowContainer.tsx
Outdated
Show resolved
Hide resolved
r100-stack
changed the base branch from
r/unit-tests-to-e2e
to
r/overflow-container
mayank99
reviewed
Oct 8, 2024
There was a problem hiding this comment.
While this isn't exactly what I had envisioned from an OverflowContainer component (esp. the whole context thing), I don't want to block the PR and I don't have the time to look more deeply and make better suggestions. So I'm ok with this, especially since it's an internal component.
What follows is mostly minor comments around code structure.
packages/itwinui-react/src/utils/components/OverflowContainer.tsx
Outdated
Show resolved
Hide resolved
packages/itwinui-react/src/utils/components/OverflowContainer.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Mayank <[email protected]>
r100-stack
force-pushed
the
r/overflow-container-without-new-algorithm
branch
from
06f48ab
to
33a02d6
Compare
mayank99
approved these changes
Oct 11, 2024
mayank99
reviewed
Oct 11, 2024
…without-new-algorithm
…iner-without-new-algorithm
r100-stack
changed the base branch from
main
to
r/table-paginator-arrow-keys-bug
mayank99
approved these changes
Oct 15, 2024
smmr-dn
approved these changes
Oct 16, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Pulled out of #2120 as PR 3 in the PR stack (PR stack order).
This just adds the
OverflowContainercomponent from the combined PR but continues to use the existinguseOverflowalgorithm. Additionally, all components now useOverflowContainerinstead ofuseOverflow.OverflowContainer: Takes theitemsprop (would likely be removed in later PRs in the PR stack), passes it touseOverflow(), and put the returnedvisibleItemsalong with theitems.lengthin a context.useOverflowContainerContext(): Can be used in components underOverflowContainerto access the context values in OverflowContainer. (#2152 (comment))OverflowContainer.OverflowNode: Wrap overflow content in this component to conditionally render it when overflowing.I also had to make a small css change to make the
iui-breadcrumbs-liststretch to the width ofiui-breadcrumbs. This was needed to constrain the width and thus trigger an overflow when the width of the container is smaller than the required width.Testing
Docs
OverflowContainer's API will change, the JSDocs are currently concise. They will be expanded upon in later PRs in this PR stack.After PR TODOs: