-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use round()
in transform
s
#2064
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayank99
requested review from
r100-stack and
Ben-Pusey-Bentley
and removed request for
a team
May 23, 2024 21:49
This comment was marked as outdated.
This comment was marked as outdated.
r100-stack
approved these changes
May 24, 2024
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This code shows the improvement better: Code
The header text is still blurry in the after image, but the text inside of the table rows isn't blurry anymore. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR helps with #1551 by rounding some percentage values to the nearest pixel, using the brand-new
round()
CSS function. This is mainly intransform
s indialog
andexpandable-block
. And for browsers that don't supportround()
, the unrounded fallback will continue to be used.Unrelated to the
round()
change but might possibly help towards #1551: simplifiedinformation-panel
to removetransform: translate(0)
.I don't think this PR is the "ultimate" fix, so I'm not linking the issue to be closed. But it's a small net improvement nonetheless.
Implementation notes:
Round()
instead ofround()
to disambiguate from the Sassround()
function.@supports
blocks which would normally be unnecessary, becauselightningcss
was trying to "minify" the CSS by removing repeated instances of the same property.Testing
I tried to test in my Windows VM with some of the sandboxes linked in #1551. It was somewhat difficult to reproduce the issues in the first place, but I did see an improvement in at least one situation:
Screenshots
Further testing on a real Windows machine would be useful. (Make sure to update to Chrome 125)
Docs
Added changesets.