remove overflow and inline transform from Dialog
#1795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r100-stack
reviewed
Jan 24, 2024
r100-stack
approved these changes
Jan 24, 2024
siddhantrawal
approved these changes
Jan 24, 2024
Merged
mayank99
added a commit
that referenced
this pull request
Jan 25, 2024
(backported to v2) This fixes blurring and avoids issues with dialog becoming off-center when the window is resized. The overflow is already handled by Dialog.Content, which is required in v3 but optional in v2. For this reason, I've kept some of the checks around (even though they were removed in #1795).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR removes a bunch of code added in #1424 and #1693.
overflow: hidden. It causes blurring and is not needed becauseDialog.Contentalready has overflow (and is required after feat(Dialog): All variants useflex#1269).:has/data-iui-flexstuff is also redundant because dialog is already using flex by default.transformstyle. It breaks window resizing and is unnecessary because removingoverflow: hiddenis enough to avoid blurring.Testing
Existing tests pass. Verified in Chrome Windows that there is no blurring and that the dialog repositions when the window is resized.
Screen.Recording.2024-01-24.at.3.51.57.PM.mov
Docs
Added changeset.