Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating all unit tests and types tests to vitest. #1784

Merged
merged 83 commits into from
Jan 29, 2024

Conversation

siddhantrawal
Copy link
Contributor

@siddhantrawal siddhantrawal commented Jan 16, 2024

Part of #1571

Changes

Followed this guide: https://vitest.dev/guide/migration.html#migrating-from-jest

Testing

All test cases are passing.

Docs

N/A

TODOs after PR Merge:

@siddhantrawal siddhantrawal self-assigned this Jan 16, 2024
packages/itwinui-react/tsconfig.json Outdated Show resolved Hide resolved
packages/itwinui-react/vitest.config.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@mayank99 mayank99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 It runs faster and feels much nicer overall compared to jest.

Copy link
Member

@r100-stack r100-stack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@siddhantrawal siddhantrawal merged commit 44b38f8 into main Jan 29, 2024
16 checks passed
@siddhantrawal siddhantrawal deleted the siddhant/migrate_tests branch January 29, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants