Remove outdated STYLEGUIDE point (#2244)

iTwin · Sep 23, 2024 · e2f953a · e2f953a
1 parent f800d53
commit e2f953a
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 81 deletions.
diff --git a/STYLEGUIDE.md b/STYLEGUIDE.md
@@ -80,39 +80,6 @@ export const Alert = (props: AlertProps) => {
   ...
 ```
 
-### Destruct props and set default values
-
-```jsx
-// Good
-export const Alert = (props: AlertProps) => {
-  const {
-    children,
-    className,
-    type = 'informational',
-    clickableText,
-    onClick,
-    onClose,
-    style,
-    isSticky = false,
-  } = props;
-  ...
-```
-
-```jsx
-// Bad
-export const Alert = ({
-    children,
-    className,
-    type = 'informational',
-    clickableText,
-    onClick,
-    onClose,
-    style,
-    isSticky = false,
-  }: AlertProps) => {
-  ...
-```
-
 ### Use classnames object syntax for conditional classes
 
 ```jsx

diff --git a/packages/itwinui-react/src/core/SearchBox/SearchBox.tsx b/packages/itwinui-react/src/core/SearchBox/SearchBox.tsx
@@ -23,54 +23,6 @@ import type {
 import type { IconButtonProps } from '../Buttons/IconButton.js';
 import type { IconProps } from '../Icon/Icon.js';
 
-const SearchBoxContext = React.createContext<
-  | {
-      /**
-       * Context prop for sizing subcomponents
-       */
-      size?: 'small' | 'large';
-      /**
-       * Context prop for disabling subcomponents
-       */
-      isDisabled?: boolean;
-      /**
-       * Id to pass to input
-       */
-      inputId: string;
-      /**
-       * Callback to set inputID
-       */
-      setInputId: (inputId: string) => void;
-      /**
-       * Ref for input subcomponent
-       */
-      inputRef: React.RefObject<HTMLInputElement>;
-      /**
-       * Ref for open button subcomponent
-       */
-      openButtonRef: React.RefObject<HTMLButtonElement>;
-      /**
-       * Callback for closing expandable searchbox
-       */
-      onCollapse?: () => void;
-      /**
-       * Callback for expanding searchbox
-       */
-      onExpand?: () => void;
-      /**
-       * SearchBox state
-       */
-      isExpanded?: boolean;
-      /**
-       * Is SearchBox expandable
-       */
-      expandable?: boolean;
-    }
-  | undefined
->(undefined);
-
-// ----------------------------------------------------------------------------
-
 type SearchBoxOwnProps = {
   /**
    * Whether the searchbox is expandable.
@@ -99,6 +51,39 @@ type SearchBoxOwnProps = {
   size?: 'small' | 'large';
 };
 
+// ----------------------------------------------------------------------------
+
+const SearchBoxContext = React.createContext<
+  | ({
+      /**
+       * Context prop for disabling subcomponents
+       */
+      isDisabled?: boolean;
+      /**
+       * Id to pass to input
+       */
+      inputId: string;
+      /**
+       * Callback to set inputID
+       */
+      setInputId: (inputId: string) => void;
+      /**
+       * Ref for input subcomponent
+       */
+      inputRef: React.RefObject<HTMLInputElement>;
+      /**
+       * Ref for open button subcomponent
+       */
+      openButtonRef: React.RefObject<HTMLButtonElement>;
+    } & Pick<
+      SearchBoxOwnProps,
+      'size' | 'onCollapse' | 'expandable' | 'isExpanded' | 'onExpand'
+    >)
+  | undefined
+>(undefined);
+
+// ----------------------------------------------------------------------------
+
 const SearchBoxComponent = React.forwardRef((props, ref) => {
   const {
     size,