Enable type checks for all stories (#2234)

Co-authored-by: Rohan <[email protected]>
iTwin · Sep 13, 2024 · 5537768 · 5537768
1 parent 4f954e4
commit 5537768
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 16 deletions.
diff --git a/apps/react-workshop/src/InformationPanel.stories.tsx b/apps/react-workshop/src/InformationPanel.stories.tsx
@@ -3,7 +3,7 @@
  * See LICENSE.md in the project root for license terms and full copyright notice.
  *--------------------------------------------------------------------------------------------*/
 import React from 'react';
-import { CellProps } from '@itwin/itwinui-react/react-table';
+import type { CellProps, Column } from '@itwin/itwinui-react/react-table';
 import { SvgEdit } from '@itwin/itwinui-icons-react';
 import {
   InformationPanel,
@@ -33,13 +33,13 @@ export const Basic = () => {
       { id: 'name', Header: 'Name', accessor: 'name' },
       {
         Header: 'Details',
-        Cell: ({ row: { index } }: CellProps<{ name: string }>) => (
+        Cell: ({ row: { index } }: CellProps<Record<string, string>>) => (
           <Button onClick={() => setOpenRowIndex(index)}>Details</Button>
         ),
       },
     ],
     [],
-  );
+  ) satisfies Column[];
 
   const data = React.useMemo(
     () =>
@@ -119,7 +119,7 @@ export const Horizontal = () => {
       },
     ],
     [],
-  );
+  ) satisfies Column<{ name: string }>[];
 
   const data = React.useMemo(
     () =>
@@ -192,7 +192,7 @@ export const CustomActions = () => {
       },
     ],
     [],
-  );
+  ) satisfies Column<{ name: string }>[];
 
   const [data, setData] = React.useState(() =>
     [...Array(10).fill(null)].map((_, index) => ({

diff --git a/apps/react-workshop/src/Select.stories.tsx b/apps/react-workshop/src/Select.stories.tsx
@@ -157,7 +157,7 @@ export const Custom = () => {
     <Select
       options={options}
       value={selectedValue}
-      onChange={setSelectedValue}
+      onChange={(value) => setSelectedValue(value)}
       placeholder='Placeholder text'
       itemRenderer={(option) => (
         <MenuItem style={{ color: option.value }}>{option.label}</MenuItem>

diff --git a/apps/react-workshop/src/TransferList.stories.tsx b/apps/react-workshop/src/TransferList.stories.tsx
@@ -36,8 +36,8 @@ export const Basic = () => {
 
   const transfer = (
     fromData: Array<TransferItemDataType>,
-    setFromData: (data: Array<TransferItemDataType>) => void,
-    setToData: (data: Array<TransferItemDataType>) => void,
+    setFromData: React.Dispatch<React.SetStateAction<TransferItemDataType[]>>,
+    setToData: React.Dispatch<React.SetStateAction<TransferItemDataType[]>>,
     sendAll?: boolean,
   ) => {
     setToData((oldToData) => {
@@ -170,8 +170,8 @@ export const WithLabel = () => {
 
   const transfer = (
     fromData: Array<TransferItemDataType>,
-    setFromData: (data: Array<TransferItemDataType>) => void,
-    setToData: (data: Array<TransferItemDataType>) => void,
+    setFromData: React.Dispatch<React.SetStateAction<TransferItemDataType[]>>,
+    setToData: React.Dispatch<React.SetStateAction<TransferItemDataType[]>>,
     sendAll?: boolean,
   ) => {
     setToData((oldToData) => {

diff --git a/apps/react-workshop/tsconfig.build.json b/apps/react-workshop/tsconfig.build.json
@@ -1,12 +1,8 @@
 {
   "$schema": "https://json.schemastore.org/tsconfig",
   "extends": "./tsconfig.json",
-  // Temporarily testing only few story files.
-  // TODO: Fix all tsc errors in all stories and then include all stories.
-  "include": [],
-  "files": [
-    "src/Table.stories.tsx",
-    "src/Footer.stories.tsx",
+  "include": [
+    "./src/**/*.stories.tsx"
   ],
   "compilerOptions": {
     "noEmit": true