Add support for SomfyHeatingTemperatureInterface

[egguy]

Updated implementation of the SomfyHeatingTemperatureInterface.

• Use the temperature of the thermostat
• Added 2 NumberSettings, but wasn't able to see them.
• Add "Impossible to change from the box" mode selection (cooling/heating).
• Mostly working
• Need to add some constant to pyOverKiz

Sorry if the pull request is not in the good format. It's mostly my first one.

[tetienne]

Hi, many thanks for this 1st contribution, any help are welcome 🎉 I haven’t yet look at your code, as you can see you have too many files modified. It’s probably because your branch is out of sync with our repo. To solve this:

git fetch --all
git rebase upstream/master
# Check you haven’t any conflicts, if yes solve them. 
git push --force-with-lease

Once done, your PR will be ready for our review :)

[egguy]

Ok, I followed your procedure, I hope I didn't make a mistake.

[tetienne]

I’ve updated the base branch. Apparently, we only have your modification now.

[iMicknl]

@egguy I just updated your branch to use the latest fixes for the coordinator (double casting) and updates pyoverkiz to 1.1.1.

[egguy]

Pulled the changes. Now the OverkizNumber input are working. (need to comment the step parameter)
What's remain to allow the pull request to be integrated ?

Ps: What is the relation between ha-tahoma and overkiz in core ? Is ha-tahoma the test integration ?

[iMicknl]

Looks good to me. Let's merge if another maintainer approves :-).

[iMicknl]

Ps: What is the relation between ha-tahoma and overkiz in core ? Is ha-tahoma the test integration ?

This integration is a bit behind on some parts now, since we had great code reviews in core. However, the aim is to migrate the integration 1:1 to core, but that will take quite some time. Eventually ha-tahoma will be the test integration, and core will be the production.

See #697 for the progress and what is still due (a lot! 😄 ).

[egguy]

Ps: What is the relation between ha-tahoma and overkiz in core ? Is ha-tahoma the test integration ?

This integration is a bit behind on some parts now, since we had great code reviews in core. However, the aim is to migrate the integration 1:1 to core, but that will take quite some time. Eventually ha-tahoma will be the test integration, and core will be the production.

See #697 for the progress and what is still due (a lot! smile ).

The overkiz integration is mostly for covers at the moment ? Or does it manage the other types of devices ?

[iMicknl]

The overkiz integration is mostly for covers at the moment ? Or does it manage the other types of devices ?

The Overkiz integration (1:1 copy from ha-tahoma) doesn't have the cover platform yet. See the issue I linked to see which platforms are already merged.

[vlebourl]

Are @tetienne 's requested changes included? if so, we should dismiss the review and proceed.

[egguy]

I have applied the requested changes. For the codespell error, it comes from a URL. :s

[egguy]

I have added the pre-commit to my env to prevent more problems in the future.

[iMicknl]

Thanks again! Happy to merge if the other users confirms that this works. #705

[iMicknl]

@egguy do you perhaps want to port this one to core? :)
Otherwise I will have a look in the coming weeks.

[egguy]

Hi, i'm already doing the port ATM. Hope to be able to commit soon.