Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for pedestrian position #598

Merged
merged 6 commits into from
Oct 16, 2021

Conversation

tetienne
Copy link
Collaborator

@tetienne tetienne commented Oct 12, 2021

Fix #597

This PR add a select to... select the state of the pedestrian gate.

I’m affraid it will require #167 to be fixed, to see the correct option always selected.

But at least, end user can select the state he want.

@github-actions github-actions bot added the enhancement New feature or request label Oct 12, 2021
custom_components/tahoma/select.py Outdated Show resolved Hide resolved
custom_components/tahoma/select.py Outdated Show resolved Hide resolved
custom_components/tahoma/select.py Outdated Show resolved Hide resolved
Copy link
Owner

@iMicknl iMicknl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we will have more select entities? Perhaps we can do something like #603, to make it more modular?

@tetienne
Copy link
Collaborator Author

The other ones I think about are some climate devices where you can only select the mode: eco, comfort etc...

@iMicknl iMicknl marked this pull request as ready for review October 16, 2021 20:35
@iMicknl
Copy link
Owner

iMicknl commented Oct 16, 2021

The other ones I think about are some climate devices where you can only select the mode: eco, comfort etc...

Let's not overcomplicate. We can always make this more modular, when we need to add more select entities.

@iMicknl iMicknl merged commit a049094 into master Oct 16, 2021
@iMicknl iMicknl deleted the enhancement/cover/pedestrian-position branch October 16, 2021 20:49
@NicoLeOca
Copy link

Hi

Somehow, after upgrading, the select entity created by @tetienne disapeared

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Pedestrian Mode - DiscreteGateWithPedestrianPosition (io:DiscreteGateOpenerIOComponent)
3 participants