Add service to refresh states on TaHoma box #241
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Aug 30, 2020
|
Why not create an other coordinator that will call regularly the refresh request? |
That would be my next step. This was just to test if this command works, since I cannot test it myself unfortunately. |
|
How would we decide the frequency of those refresh? We have to profile that code before making it automatic to be sure it doesn't consume too much resources. |
|
How does this fix #223? |
Not sure yet. In HomeBridge they make this configurable and I saw many people putting it pretty low (60 seconds). |
iMicknl
force-pushed
the
feature/add_refresh_states_service
branch
from
03110e4
to
cd7410b
Compare
iMicknl
force-pushed
the
feature/add_refresh_states_service
branch
from
f6b8690
to
a06f194
Compare
Signed-off-by: Mick Vleeshouwer <[email protected]>
iMicknl
force-pushed
the
feature/add_refresh_states_service
branch
from
a06f194
to
30b6ed3
Compare
commit 39baced Author: Mick Vleeshouwer <[email protected]> Date: Mon Sep 14 10:00:18 2020 +0200 Improve `stop` and `stop tilt` command for covers (#251) commit af03275 Author: Vincent Le Bourlot <[email protected]> Date: Thu Sep 10 12:35:42 2020 +0200 Rename UNIT_PERCENTAGE to PERCENTAGE (#257) commit 34eeb61 Author: Vincent Le Bourlot <[email protected]> Date: Fri Sep 4 11:38:53 2020 +0200 Add support for StatelessExteriorHeating device. (#244) * Add support for StatelessExteriorHeating device. * Add support for StatelessExteriorHeating device. * Changed unknown property to None. Added SUPPORT_PRESET_MODE. * Added services to services.yaml, removed up and down services. #211 * Fix temperature unit. #211 * Fix types. #211 * limit service my to supported devices. #211 * Added some debug logs. * Merge master into branch. * fixed wrong import #211 * Add last ha action as preset and hvac mode state. #211 * Renamed service. #211 * Revert "Add last ha action as preset and hvac mode state." This reverts commit bdfb6f3 #211 * improved debug logging. #211 * improved debug logging. #211 * fix possible circular import. #211 * Removed service * Changed preset to my only * Removed commented lines. * Cleaned up code. * Cleaned up code. * Removed unwanted logging message. #211 * Switch mode and preset back to None. #211 * cleanup code. #211 commit a95fb73 Author: Vincent Le Bourlot <[email protected]> Date: Fri Sep 4 09:57:46 2020 +0200 Add service to send any command to tahoma. (#252) * Add service to send any command to tahoma. * Fixed jsons. * Update strings.json * Applied comments. * Add service to send any command to tahoma. * Rebased onto master. * Cleanup leftovers. * Cleanup some more leftovers. commit 7a19a7c Author: Mick Vleeshouwer <[email protected]> Date: Thu Sep 3 11:39:59 2020 +0200 Add support for DomesticHotWaterTank (#247) Signed-off-by: Mick Vleeshouwer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A first try to solve the issues around states for devices that need a refresh. In this PR a service is added to manually refresh the states. If this is the solution, we could add this as an option to the DataUpdateCoordinator.
Fixes #167, #233, #230
Please note that after the refresh is complete, the event needs to be fetched via the DataUpdateCoordinator.
2020-08-30 12:08:58 DEBUG (MainThread) [custom_components.tahoma.coordinator] RefreshAllDevicesStatesCompletedEvent/None (device:None,state:None->None)