Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Major update of Telescope class #631

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open

Major update of Telescope class #631

wants to merge 29 commits into from

Commits on Oct 29, 2024

  1. Warning properly formatted (no newline)

    @anawas
    anawas committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    6b2d2be View commit details
    Browse the repository at this point in the history

  2. Testing baseline functionality for OSKAR telescope 📀

    @anawas
    anawas committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    b66dde5 View commit details
    Browse the repository at this point in the history

  3. Added comment about which value for Earth radius astropy uses 🪲

    @anawas
    anawas committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    ae119f5 View commit details
    Browse the repository at this point in the history

  4. Added test for coordinate_helper functions 💬

    @anawas
    anawas committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    ce8f34e View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. Set Earth radius to more precise value ⭐

    @anawas
    anawas committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    e910983 View commit details
    Browse the repository at this point in the history

  2. using build in conversions for rad <-> deg 🚊

    @anawas
    anawas committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    aff02b9 View commit details
    Browse the repository at this point in the history

  3. Add test for east_north function 💒

    @anawas
    anawas committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    6e14340 View commit details
    Browse the repository at this point in the history

  4. parametrized test ➗

    @anawas
    anawas committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    8668164 View commit details
    Browse the repository at this point in the history

  5. removed print statement 😬

    @anawas
    anawas committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    694a8d5 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2024

  1. Added documentation 👭

    @anawas
    anawas committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    15f2886 View commit details
    Browse the repository at this point in the history

  2. Make clear that backend is OSKAR 🚘

    @anawas
    anawas committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    f881dee View commit details
    Browse the repository at this point in the history

  3. Must be able to set name of RASCIL telescope 🍴

    @anawas
    anawas committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    eb8cbda View commit details
    Browse the repository at this point in the history

  4. Add test to assert name can be set. 📠

    @anawas
    anawas committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    ea96a8c View commit details
    Browse the repository at this point in the history

  5. Fixed typo 😐

    @anawas
    anawas committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    21198dc View commit details
    Browse the repository at this point in the history

  6. Function to convert RASCIl to OSKAR 🎽

    @anawas
    anawas committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    43fe31d View commit details
    Browse the repository at this point in the history

  7. Function creates KARABO telescope from RASCIL dataset 😐

    @anawas
    anawas committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    5b4ad5a View commit details
    Browse the repository at this point in the history

  8. First test for new RASCIL functionality 🔺

    @anawas
    anawas committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    5d267ec View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2024

  1. Refactored to own method 🐗

    @anawas
    anawas committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    d595dd1 View commit details
    Browse the repository at this point in the history

  2. Calculating combinations is easier with itertools ➖

    @anawas
    anawas committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    df047fd View commit details
    Browse the repository at this point in the history

  3. Better wording (a baseline has a length) 📹

    @anawas
    anawas committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    12ce08e View commit details
    Browse the repository at this point in the history

  4. Renaming baselines -> stations because the values are coordinates of … 

    …stations (antennas) 🕜
    @anawas
    anawas committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    fce940c View commit details
    Browse the repository at this point in the history

  5. Refactored baseline code 🇨🇳

    @anawas
    anawas committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    bb29d21 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. Edit comment ↔️

    @anawas
    anawas committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    f2b7fef View commit details
    Browse the repository at this point in the history

  2. Must set delimiter or we get an error 🌻

    @anawas
    anawas committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    4621fc5 View commit details
    Browse the repository at this point in the history

  3. Must set delimiter or we cannot read in wit _get_station_infos() 😆

    @anawas
    anawas committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    76984df View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. Function __read_layout_txt is more robust than np.loadtxt 👪

    @anawas
    anawas committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    0ff4ad2 View commit details
    Browse the repository at this point in the history

  2. Using karabo functions to create tmp folder. This is consistent with … 

    …rest of code. 🎂
    @anawas
    anawas committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    a63d514 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. Edit test for create_baseline_cut_telescope 🌱

    @anawas
    anawas committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    6dbbf8d View commit details
    Browse the repository at this point in the history

  2. Narrowing of type now done properly 👶

    @anawas
    anawas committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    b4c77f7 View commit details
    Browse the repository at this point in the history