Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#119): add error presenter function to edit GraphQL error message #123

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

kgrigorev
Copy link
Contributor

In order to address this issue #119 this PR adds ErrorPresenter function which can edit GraphQL validation error messages based on the type of an error. In this case the sentence containing GraphQL type suggestions is trimmed from the error message

@carstendietrich carstendietrich changed the title feat(300544): add error presenter function to edit GraphQL error message feat(#119): add error presenter function to edit GraphQL error message Sep 17, 2024
Copy link
Member

@carstendietrich carstendietrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please fix the lint issues and rename the error presenter to something more meaningful. 🚀

error_presenter.go Outdated Show resolved Hide resolved
@carstendietrich carstendietrich merged commit 32e0eb3 into i-love-flamingo:master Sep 18, 2024
4 checks passed
@github-actions github-actions bot mentioned this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants