Timestamp Configs for FlatPostgresCollection#274
Open
suddendust wants to merge 23 commits intohypertrace:mainfrom
Open
Timestamp Configs for FlatPostgresCollection#274suddendust wants to merge 23 commits intohypertrace:mainfrom
suddendust wants to merge 23 commits intohypertrace:mainfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #274 +/- ##
============================================
- Coverage 81.01% 80.94% -0.08%
- Complexity 1446 1467 +21
============================================
Files 241 243 +2
Lines 6979 7074 +95
Branches 648 662 +14
============================================
+ Hits 5654 5726 +72
- Misses 907 923 +16
- Partials 418 425 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…pg_writes_timestampConfig
This reverts commit e86721a.
|
This will be doable at what level? Per table ? |
…ument-store into pg_writes_timestampConfig
Contributor
Author
|
This will be doable at what level? Per table ? @puneet-traceable Added this at collection level. |
…rites_timestampConfig
…rites_timestampConfig
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Config-Driven Timestamp Fields for Flat Collections
Summary
Adds auto-managed
createdTimeandlastUpdateTimefields for flat PostgreSQL collections, configurable viaPostgresClientcustom parameters.Changes
BIGINT→ epoch millis,TIMESTAMPTZ→java.sql.Timestamp, etc.)createdTimepreserved on updates,lastUpdateTimealways updatedNULLTesting
testTimestampsOnCreate- Validates both fields populated on createtestTimestampsOnUpsert- ValidatescreatedTimepreserved,lastUpdateTimeupdatedtestNoExceptionWhenTimestampConfigMissing- Validates graceful handling when config absent.For upserts, here's an example query that is created:
Callout
Note that there is no way to define a global timestamp config and override it at a per-collection level. The reason I have excluded this in this PR is because a proper config override framework requires a bit more thought - For example, how we merge global properties with local overrides. That would increase the scope of this PR and I feel it's better taken care of in a separate PR.