Add Windows Rtools build support and declare C++17 requirement#3
Open
Add Windows Rtools build support and declare C++17 requirement#3
Conversation
- Create src/Makevars.win for explicit Windows build configuration - Add CXX_STD = CXX17 to both Makevars and Makevars.win (required by if constexpr usage in vendored GeographicLib source) - Set GEOGRAPHICLIB_SHARED_LIB=0 via PKG_CPPFLAGS (correct for vendored static library compiled into R package DLL) - Add SystemRequirements: C++17 to DESCRIPTION per CRAN policy https://claude.ai/code/session_01DwoeJSvX2GEdAv1s8HaN7J
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://claude.ai/code/session_01DwoeJSvX2GEdAv1s8HaN7J