-
-
Notifications
You must be signed in to change notification settings - Fork 1
Feat/next instpector #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/next instpector #36
Conversation
…omponents to streamline removal process
WalkthroughThis change refactors the removal logic in the Overlay and InspectContextPanel components by eliminating explicit React root unmounting. Both components now remove their respective DOM elements directly without calling the unmount method, streamlining the component removal process without altering public APIs or introducing new logic. Changes
Poem
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.changeset/chatty-apples-taste.md (1)
5-5: Polish the changeset summary for consistency with Conventional Commits style.Changeset summaries become part of the generated changelog; they should be concise, imperative, and avoid category prefixes that are already encoded by the semver bump. Consider:
-refactor: remove unmount logic from Overlay and InspectContextPanel components to streamline removal process +Remove explicit unmount logic from Overlay and InspectContextPanel to streamline component cleanup.This drops the redundant “refactor:” label, starts with a capital verb, and ends with a period for consistency.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.changeset/chatty-apples-taste.md(1 hunks)packages/inspector-component/src/overlay/Overlay.tsx(0 hunks)packages/inspector-component/src/panel/InspectContextPanel.tsx(0 hunks)
💤 Files with no reviewable changes (2)
- packages/inspector-component/src/panel/InspectContextPanel.tsx
- packages/inspector-component/src/overlay/Overlay.tsx
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: test (18.x)
- GitHub Check: deploy (20.x)
- GitHub Check: test (18.x)
🔇 Additional comments (1)
.changeset/chatty-apples-taste.md (1)
2-3: Patch bump looks correct.Removing internal unmount logic shouldn’t affect the public-API surface, so a patch bump for
@hyperse/inspector-componentis appropriate.
remove unmount logic from Overlay and InspectContextPanel components to streamline removal process
Summary by CodeRabbit