Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Pluto.migrations updating to vi #348

Merged
merged 1 commit into from
Jan 2, 2025
Merged

test: Pluto.migrations updating to vi #348

merged 1 commit into from
Jan 2, 2025

Conversation

curtis-h
Copy link
Contributor

@curtis-h curtis-h commented Dec 12, 2024

Description:

Moving tests away from old style chai / sinon implementation to vitest.
Slight simplification to use specific models instead of using the Repositories to generate them.

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

@curtis-h curtis-h self-assigned this Dec 12, 2024
@curtis-h curtis-h requested a review from a team as a code owner December 12, 2024 12:48
Copy link

github-actions bot commented Dec 12, 2024

Lines Statements Branches Functions
Coverage: 75%
76.12% (3648/4792) 66.53% (1676/2519) 80.35% (867/1079)

@coveralls
Copy link

coveralls commented Dec 12, 2024

Coverage Status

coverage: 72.571% (+0.01%) from 72.557%
when pulling bf48021 on test/pluto-tidy
into 00ddc08 on main.

@elribonazo
Copy link
Contributor

@amagyar-iohk Don't really like blocking PR's because coverage dropped 0.04

@curtis-h curtis-h merged commit 6316a31 into main Jan 2, 2025
7 checks passed
@curtis-h curtis-h deleted the test/pluto-tidy branch January 2, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants