Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add e2e tests for different createCredentialOffer API variations #1476

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

feat: add e2e tests for different createCredentialOffer API variations #1476

wants to merge 21 commits into from
+465 −68

Conversation

yshyn-iohk
Copy link
Member

@yshyn-iohk yshyn-iohk commented Dec 12, 2024 •
edited
Loading

Description:

The goal of this PR is to add tests for improved API to make a credentialOffer

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

@yshyn-iohk
chore: update the dependencies of Kotlin and TypeScript HTTP client
8586601 
Signed-off-by: Yurii Shynbuiev <[email protected]>
@yshyn-iohk
style: fix ktlint errors
94e23fe 
Signed-off-by: Yurii Shynbuiev <[email protected]>
@yshyn-iohk
Merge remote-tracking branch 'refs/remotes/origin/main' into feat/vcd…
826bc8b 
…m1_1-tests

# Conflicts:
#	tests/performance-tests/agent-performance-tests-k6/package.json
#	tests/performance-tests/agent-performance-tests-k6/yarn.lock
@yshyn-iohk
test: add CredentialSchemaReferenceParsingLogicSpec
f350b22 
Signed-off-by: Yurii Shynbuiev <[email protected]>
@yshyn-iohk
Merge remote-tracking branch 'refs/remotes/origin/main' into feat/vcd…
37b5db2 
…m1_1-tests
@yshyn-iohk
test: add e2e test stub for different API variations
27e3a27 
Signed-off-by: Yurii Shynbuiev <[email protected]>
@yshyn-iohk
Merge remote-tracking branch 'refs/remotes/origin/main' into feat/vcd…
2026482 
…m1_1-tests
@yshyn-iohk yshyn-iohk requested a review from a team as a code owner December 12, 2024 11:52
@yshyn-iohk yshyn-iohk changed the title [WIP] test: add e2e tests for different createCredentialOffer API variations test: add e2e tests for different createCredentialOffer API variations Dec 12, 2024
@yshyn-iohk yshyn-iohk marked this pull request as draft December 12, 2024 12:06
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 12, 2024 •
edited
Loading

Unit Test Results

105 files  +1  105 suites  +1   21m 9s ⏱️ + 4m 23s
889 tests +7  881 ✅ +7  8 💤 ±0  0 ❌ ±0 
896 runs  +7  888 ✅ +7  8 💤 ±0  0 ❌ ±0 

Results for commit c36c0d9. ± Comparison against base commit 1e19b04.

♻️ This comment has been updated with latest results.

@coveralls
Copy link

coveralls commented Dec 12, 2024 •
edited
Loading

Coverage Status

coverage: 48.674% (+0.09%) from 48.589%
when pulling c36c0d9 on feat/vcdm1_1-tests
into 1e19b04 on main.

@yshyn-iohk
fix: adjust CreateIssuerCredentialRecordRequest params
496ce0d 
Signed-off-by: Yurii Shynbuiev <[email protected]>
@yshyn-iohk
fix: adjust CreateIssuerCredentialRecordRequest params #2
01bb43a 
Signed-off-by: Yurii Shynbuiev <[email protected]>
@yshyn-iohk
test: add tests for new API
9c8e032 
Signed-off-by: Yurii Shynbuiev <[email protected]>
@yshyn-iohk
Merge remote-tracking branch 'refs/remotes/origin/main' into feat/vcd…
8125db8 
…m1_1-tests

# Conflicts:
#	cloud-agent/client/kotlin/src/main/kotlin/org/hyperledger/identus/client/models/CreateIssueCredentialRecordRequest.kt
#	cloud-agent/service/server/src/main/scala/org/hyperledger/identus/issue/controller/IssueControllerImpl.scala
#	tests/integration-tests/build.gradle.kts
#	tests/performance-tests/agent-performance-tests-k6/package.json
#	tests/performance-tests/agent-performance-tests-k6/yarn.lock
@yshyn-iohk
fix: outdated test
16c17ce 
Signed-off-by: Yurii Shynbuiev <[email protected]>
@yshyn-iohk
test: stabilize e2e build
ca495d2 
Signed-off-by: Yurii Shynbuiev <[email protected]>
@yshyn-iohk
Merge branch 'main' into feat/vcdm1_1-tests
5c89fa3
@yshyn-iohk
style: megalinter fixes
f9d1430 
Signed-off-by: Yurii Shynbuiev <[email protected]>
@yshyn-iohk
chore: fix typos in e2e tests
82addfa 
Signed-off-by: Yurii Shynbuiev <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 15, 2025 •
edited
Loading

Integration Test Results

 22 files  +2   22 suites  +2   2s ⏱️ ±0s
 56 tests +1   56 ✅ +1  0 💤 ±0  0 ❌ ±0 
101 runs  +4  101 ✅ +4  0 💤 ±0  0 ❌ ±0 

Results for commit c36c0d9. ± Comparison against base commit 1e19b04.

♻️ This comment has been updated with latest results.

@yshyn-iohk yshyn-iohk marked this pull request as ready for review January 16, 2025 11:03
@yshyn-iohk yshyn-iohk changed the title test: add e2e tests for different createCredentialOffer API variations feat: add e2e tests for different createCredentialOffer API variations Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mineme0110 mineme0110 mineme0110 approved these changes

Assignees
No one assigned
Labels
cloud-agent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yshyn-iohk @coveralls @mineme0110