Fix disabled test in BonsaiWorldStateProviderTest #8554
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-enables the previously disabled test testGetMutableWithRollbackNotOverrideTrieLogLayer by refactoring it to properly verify that saveTrieLog is not called when a trie log already exists for a block. The test now correctly checks that the TrieLogManager never attempts to save a trie log for a block that already has one, which was the original intent of the test. The issue was that the previous implementation was trying to trigger saveTrieLog through getWorldState, but that method doesn't directly trigger the saving process. The refactored test now properly mocks the dependencies and verifies the correct behavior using withBlockHeaderAndNoUpdateNodeHead instead of withStateRootAndBlockHashAndUpdateNodeHead. Signed-off-by: GarmashAlex <[email protected]>
matkt
reviewed
Apr 17, 2025
| bonsaiWorldStateArchive.getWorldState( | ||
| withStateRootAndBlockHashAndUpdateNodeHead(null, blockHeaderChainB.getHash()))) | ||
| .containsInstanceOf(BonsaiWorldState.class); | ||
| withBlockHeaderAndNoUpdateNodeHead(blockHeaderChainB))) |
Contributor
There was a problem hiding this comment.
could you do the test with withBlockHeaderAndUpdateNodeHead and not withBlockHeaderAnd_No_UpdateNodeHead
Author
There was a problem hiding this comment.
could you do the test with withBlockHeaderAndUpdateNodeHead and not withBlockHeaderAnd_No_UpdateNodeHead
done
Contributor
There was a problem hiding this comment.
tried on my side and the test is not working
Signed-off-by: GarmashAlex <[email protected]>
Contributor
|
I removed this test and added a new tests in the trielog manager tests. Seems to be more coherent to move it and it will also simplify the logic of the test #8561 . I think we can close this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-enables the previously disabled test testGetMutableWithRollbackNotOverrideTrieLogLayer by refactoring it to properly verify that saveTrieLog is not called when a trie log already exists for a block.
The test now correctly checks that the TrieLogManager never attempts to save a trie log for a block that already has one, which was the original intent of the test. The issue was that the previous implementation was trying to trigger saveTrieLog through getWorldState, but that method doesn't directly trigger the saving process.
The refactored test now properly mocks the dependencies and verifies the correct behavior using withBlockHeaderAndNoUpdateNodeHead instead of withStateRootAndBlockHashAndUpdateNodeHead.