fixes #8204 by using BadBlockManager from protocol context

[jflo]

fixes first part of #8204 by using BadBlockManager from protocol context

[matkt]

did you had time to test it with a stateroot mismatch issue ? I saw on my last test that with a stateroot mismatch we are passing here https://github.com/hyperledger/besu/pull/8207/files#diff-e390f1feab110aff3f324e7e36e681b676198067f3b8932ff3abe97f0793df50R215 and in this case we are not adding the bad block

[github-actions]

This pr is stale because it has been open for 30 days with no activity.

I'm dismissing my review pending q from matkt

[garyschulte]

did you had time to test it with a stateroot mismatch issue ? I saw on my last test that with a stateroot mismatch we are passing here https://github.com/hyperledger/besu/pull/8207/files#diff-e390f1feab110aff3f324e7e36e681b676198067f3b8932ff3abe97f0793df50R215 and in this case we are not adding the bad block

@matkt when you have a moment, pls check this commit for context: d9b0564

[matkt]

did you had time to test it with a stateroot mismatch issue ? I saw on my last test that with a stateroot mismatch we are passing here https://github.com/hyperledger/besu/pull/8207/files#diff-e390f1feab110aff3f324e7e36e681b676198067f3b8932ff3abe97f0793df50R215 and in this case we are not adding the bad block

@matkt when you have a moment, pls check this commit for context: d9b0564

I see that you are catching a new execption for the stateroot mismatch but I don't see how it could fix the issue

In my case the I had an invalid stateroot and we passed here https://github.com/hyperledger/besu/pull/8207/files#diff-e390f1feab110aff3f324e7e36e681b676198067f3b8932ff3abe97f0793df50L221. With your commit it seems to be the same or maybe I missing something 🤔

[garyschulte]

did you had time to test it with a stateroot mismatch issue ? I saw on my last test that with a stateroot mismatch we are passing here https://github.com/hyperledger/besu/pull/8207/files#diff-e390f1feab110aff3f324e7e36e681b676198067f3b8932ff3abe97f0793df50R215 and in this case we are not adding the bad block

can you give a test case? previously bonsai stateroot mismatches were never being added as bad blocks, but were being treated as a database layer problem. This PR should address that. LMK if there is a reproducible case where a stateroot mismatch does not result in adding to the bad block manager.

[matkt]

did you had time to test it with a stateroot mismatch issue ? I saw on my last test that with a stateroot mismatch we are passing here https://github.com/hyperledger/besu/pull/8207/files#diff-e390f1feab110aff3f324e7e36e681b676198067f3b8932ff3abe97f0793df50R215 and in this case we are not adding the bad block

can you give a test case? previously bonsai stateroot mismatches were never being added as bad blocks, but were being treated as a database layer problem. This PR should address that. LMK if there is a reproducible case where a stateroot mismatch does not result in adding to the bad block manager.

Don't have a unit test but it was pretty easy to reproduce the issue. I think if you force a stateroot mismatch by changing the gas cost of an operation and try to sync on mainnet you will be able to have it

[matkt]

Checked and it's working, I saw that you are using

public BlockProcessingResult(
      final Optional<BlockProcessingOutputs> yield, final String errorMessage) {
    super(errorMessage);
    this.yield = yield;
    this.isPartial = false;
  }

in case of a stateroot mismatch and not

 public BlockProcessingResult(
    final Optional<BlockProcessingOutputs> yield, final Throwable cause) {
  super(cause.getLocalizedMessage(), cause);
  this.yield = yield;
  this.isPartial = false;
}

so it will work

[matkt]

LGTM