fix: generate dids from indy seed secret bytes #1224
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Ebert <[email protected]>
Signed-off-by: James Ebert <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the Askar implementation of the did_wallet trait function
create_and_store_my_did()to match other framework implementations, such as ACA-Py, by deterministically generating a DID from a 'seed' (which in Indy is just the secret key). So this function changes the generation to use Askar'sfrom_secret_bytesinstead offrom_seed.See here for some discussion on the topic.
This required adjusting the underlying
insert_key()method to only insert aLocalKeyand leave the generation up to the call function (which seems like a better idea anyways IMO).