draft: cleanup logging dependencies #1060
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1060 +/- ##
=====================================
Coverage 0.05% 0.05%
=====================================
Files 379 379
Lines 20912 20909 -3
Branches 3853 3855 +2
=====================================
Hits 12 12
+ Misses 20899 20896 -3
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Patrik Stas <[email protected]>
Patrik-Stas
force-pushed
the
deps/cleanup1
branch
from
c23054b to
3c6932f
Compare
gmulhearn
approved these changes
Nov 19, 2023
Patrik-Stas
changed the title
Patrik-Stas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incrementally addressing #1012 (considering file reorg PR)
Outstanding:
libvcx_loggershould not exists, each top level crate such aslibvcx_core,uniffior backchannel shall setup env logger (or other log macro implementations) themselves.