Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize crates #1059

Merged
merged 5 commits into from
Nov 16, 2023
Merged

Reorganize crates #1059

merged 5 commits into from
Nov 16, 2023

Conversation

Patrik-Stas
Copy link
Contributor

@Patrik-Stas Patrik-Stas commented Nov 12, 2023

First incremental shot at #1045

Trying to move what's not currently being worked on / shouldn't cause trouble. Moves:

  • aries-vcx-agent under aries/agents/rust
  • agency_client, diddoc_legacy, libvcx_core, libvdrtools under aries/legacy
  • shared_vcx under aries/shared_vcx
  • node wrappers node and vcx-napi-rs under aries/wrappers
  • wallet_migrator under tools/

And fixes paths wherever needed

@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (db69f3c) 0.05% compared to head (d919523) 0.05%.

Files Patch % Lines
aries/legacy/libvdrtools/src/lib.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1059   +/-   ##
=====================================
  Coverage   0.05%   0.05%           
=====================================
  Files        388     388           
  Lines      21076   21076           
  Branches    3875    3875           
=====================================
  Hits          12      12           
  Misses     21063   21063           
  Partials       1       1           
Flag Coverage Δ
unittests-aries-vcx 0.05% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Patrik Stas <[email protected]>
@gmulhearn-anonyome
Copy link
Contributor

gmulhearn-anonyome commented Nov 16, 2023

should this readme be moved? https://github.com/hyperledger/aries-vcx/tree/reorg1/agents/rust , and the agents dir deleted?

gmulhearn
gmulhearn previously approved these changes Nov 16, 2023
Copy link
Contributor

@mirgee mirgee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I second George's point above; moreover, are there some pending changes to the messages crates or can the be grouped too?

aries/public_key/Cargo.toml Outdated Show resolved Hide resolved
aries/shared_vcx/Cargo.toml Outdated Show resolved Hide resolved
Signed-off-by: Patrik Stas <[email protected]>
Signed-off-by: Patrik Stas <[email protected]>
@Patrik-Stas
Copy link
Contributor Author

Patrik-Stas commented Nov 16, 2023

@mirgee didn't move messages yet as the did-exchange PR is modifying those

@Patrik-Stas Patrik-Stas merged commit 61b7cd1 into main Nov 16, 2023
28 checks passed
@Patrik-Stas Patrik-Stas deleted the reorg1 branch November 16, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants