Uniffi demo holder #1058
Merged
Uniffi demo holder #1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swaptr
force-pushed
the
uniffi-demo-holder
branch
from
2239bd1 to
04b8f20
Compare
swaptr
commented
Nov 11, 2023
uniffi_aries_vcx/demo/app/src/main/java/org/hyperledger/ariesvcx/AppDemoController.kt
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1058 +/- ##
=====================================
Coverage 0.05% 0.05%
=====================================
Files 471 471
Lines 24009 24009
Branches 4306 4306
=====================================
Hits 13 13
Misses 23995 23995
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
swaptr
force-pushed
the
uniffi-demo-holder
branch
3 times, most recently
from
1201804 to
a1fad5b
Compare
swaptr
force-pushed
the
uniffi-demo-holder
branch
2 times, most recently
from
6618551 to
d32da29
Compare
Patrik-Stas
reviewed
Nov 21, 2023
gmulhearn
reviewed
Nov 23, 2023
uniffi_aries_vcx/demo/app/src/main/java/org/hyperledger/ariesvcx/HolderScreen.kt
Outdated
Show resolved
Hide resolved
gmulhearn
reviewed
Nov 23, 2023
uniffi_aries_vcx/demo/app/src/main/java/org/hyperledger/ariesvcx/AppDemoController.kt
Outdated
Show resolved
Hide resolved
gmulhearn
reviewed
Nov 23, 2023
uniffi_aries_vcx/demo/app/src/main/java/org/hyperledger/ariesvcx/HolderScreen.kt
Outdated
Show resolved
Hide resolved
gmulhearn
requested changes
Nov 23, 2023
There was a problem hiding this comment.
Left some comments above, most just clean up stuff.
Also a general note: try to ensure that Kotlin calls into rust/uniffi are done within Dispatchers.IO. i.e. ..launch(Dispatchers.IO) {.. }
For instance, processOfferRequest is launching with viewModelScope.launch, but you'd want to launch with .launch(Dispatchers.IO). If you don't do this, then the Uniffi/rust calls are going to block the main UI thread, which is what causes UI freezes etc
swaptr
force-pushed
the
uniffi-demo-holder
branch
from
ef1287e to
fb08cb4
Compare
Signed-off-by: Swapnil Tripathi <[email protected]>
Signed-off-by: Swapnil Tripathi <[email protected]>
Signed-off-by: Swapnil Tripathi <[email protected]>
Signed-off-by: Swapnil Tripathi <[email protected]>
Signed-off-by: Swapnil Tripathi <[email protected]>
Signed-off-by: Swapnil Tripathi <[email protected]>
Signed-off-by: Swapnil Tripathi <[email protected]>
Signed-off-by: Swapnil Tripathi <[email protected]>
gmulhearn
approved these changes
Nov 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.