fix(aries_vcx): make tests run in parallel #1057
Merged
+100
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1057 +/- ##
========================================
- Coverage 0.05% 0.05% -0.01%
========================================
Files 379 379
Lines 20912 20956 +44
Branches 3853 3860 +7
========================================
Hits 12 12
- Misses 20899 20943 +44
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
xprazak2
force-pushed
the
parallel-tests
branch
from
1b8eb0c to
33f7f8b
Compare
Patrik-Stas
requested changes
Nov 12, 2023
aries_vcx/tests/utils/test_agent.rs
Outdated
| @@ -81,3 +83,38 @@ pub async fn create_test_agent( | |||
| > { | |||
| create_test_agent_from_seed(&generate_random_seed(), genesis_file_path).await | |||
| } | |||
|
|
|||
| pub async fn create_test_endorser<LW, W>( | |||
There was a problem hiding this comment.
nitpick: let's call this create_test_agent_endorser for consistency
Alternatively we could drop _test_ from all of these methods keeping it just create_agent_<foobar>
aries_vcx/tests/test_pool.rs
Outdated
| @@ -196,15 +209,28 @@ async fn test_pool_write_new_endorser_did() -> Result<(), Box<dyn Error>> { | |||
| #[ignore] | |||
| async fn test_pool_add_get_service_public() -> Result<(), Box<dyn Error>> { | |||
| let setup = build_setup_profile().await; | |||
| let did = setup.institution_did.clone(); | |||
| let acme = create_test_endorser( | |||
There was a problem hiding this comment.
nitpick: let's call this agent_endorser or perhaps just endorser
xprazak2
force-pushed
the
parallel-tests
branch
from
33f7f8b to
2380c89
Compare
fixes hyperledger#1050 Signed-off-by: Ondrej Prazak <[email protected]>
xprazak2
force-pushed
the
parallel-tests
branch
from
2380c89 to
8713945
Compare
Patrik-Stas
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1050