Refactor and strip down Aries transport abstraction and further code trimming #1040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Develops on commits from #1029 |
nain-F49FF806
force-pushed
the
nain/mediator/refactor/aries-transport-abstraction
branch
from
66bb7e1 to
c086f55
Compare
Codecov Report
@@ Coverage Diff @@
## main #1040 +/- ##
=====================================
Coverage 0.05% 0.05%
=====================================
Files 384 384
Lines 21249 21249
Branches 3835 3835
=====================================
Hits 12 12
Misses 21236 21236
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Hi Naian, indeed as you sugggested, if you base this on #1029 I can do review for this before 1029 is merged |
nain-F49FF806
force-pushed
the
nain/mediator/refactor/aries-transport-abstraction
branch
from
c086f55 to
82bae34
Compare
|
@Patrik-Stas Done. Please have a look. |
Patrik-Stas
reviewed
Nov 1, 2023
Patrik-Stas
reviewed
Nov 1, 2023
Patrik-Stas
requested changes
Nov 1, 2023
nain-F49FF806
force-pushed
the
nain/mediator/refactor/aries-transport-abstraction
branch
from
cff4ad5 to
79d5045
Compare
Barely used and uses push _aries_envelope method of AriesTransport trait, which is going to change too. Signed-off-by: Naian <[email protected]>
Send envelope and await on single response instead. Signed-off-by: Naian <[email protected]>
…in mediator proper. Signed-off-by: Naian <[email protected]>
Signed-off-by: Naian <[email protected]>
Signed-off-by: Naian <[email protected]>
connection is already tested in aries-connection test file Signed-off-by: Naian <[email protected]>
Signed-off-by: Naian <[email protected]>
Signed-off-by: Naian <[email protected]>
nain-F49FF806
force-pushed
the
nain/mediator/refactor/aries-transport-abstraction
branch
from
79d5045 to
c534273
Compare
Signed-off-by: Naian <[email protected]>
Signed-off-by: Naian <[email protected]>
nain-F49FF806
changed the title
nain-F49FF806
changed the title
Patrik-Stas
approved these changes
Nov 2, 2023
Patrik-Stas
deleted the
nain/mediator/refactor/aries-transport-abstraction
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.