Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and modify OutOfBandReceiver #1038

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Refactor and modify OutOfBandReceiver #1038

merged 1 commit into from
Oct 31, 2023

Conversation

Patrik-Stas
Copy link
Contributor

  • Refactoring
  • Modified behaviour - do not modify decorators on retrieved attached message - I don't know why this was being done in a first place (perhaps trying to be graceful toward misbehaving OOB sender message?)

@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2023

Codecov Report

Merging #1038 (8997e88) into main (2229bab) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@          Coverage Diff          @@
##            main   #1038   +/-   ##
=====================================
  Coverage   0.05%   0.05%           
=====================================
  Files        383     383           
  Lines      21288   21254   -34     
  Branches    3837    3830    -7     
=====================================
  Hits          12      12           
+ Misses     21275   21241   -34     
  Partials       1       1           
Flag Coverage Δ
unittests-aries-vcx 0.05% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
aries_vcx/src/handlers/out_of_band/receiver.rs 0.00% <0.00%> (ø)

@bobozaur bobozaur force-pushed the cleanup/oob-receiver branch from 8997e88 to ea862e2 Compare October 30, 2023 19:06
@bobozaur bobozaur merged commit a521dc4 into main Oct 31, 2023
27 checks passed
@bobozaur bobozaur deleted the cleanup/oob-receiver branch October 31, 2023 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants