-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Present Proof V2.0 message structures #1017
Merged
bobozaur
merged 8 commits into
hyperledger:main
from
anonyome:gm/present-proof-v2-messages
Oct 20, 2023
Merged
Present Proof V2.0 message structures #1017
bobozaur
merged 8 commits into
hyperledger:main
from
anonyome:gm/present-proof-v2-messages
Oct 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: George Mulhearn <[email protected]>
Signed-off-by: George Mulhearn <[email protected]>
Signed-off-by: George Mulhearn <[email protected]>
Signed-off-by: George Mulhearn <[email protected]>
Signed-off-by: George Mulhearn <[email protected]>
Signed-off-by: George Mulhearn <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1017 +/- ##
==========================================
- Coverage 36.52% 36.31% -0.22%
==========================================
Files 378 386 +8
Lines 21912 22040 +128
Branches 4035 4062 +27
==========================================
Hits 8003 8003
- Misses 11751 11877 +126
- Partials 2158 2160 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Patrik-Stas
previously approved these changes
Oct 19, 2023
bobozaur
reviewed
Oct 19, 2023
bobozaur
previously approved these changes
Oct 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Feel free to ignore the comment posted if it's not important for you.
Signed-off-by: George Mulhearn <[email protected]>
Signed-off-by: George Mulhearn <[email protected]>
gmulhearn-anonyome
dismissed stale reviews from bobozaur and Patrik-Stas
via
October 19, 2023 23:53
92e8ed9
bobozaur
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related, almost identical to: #990
NOTE: I've gone with v2.0 (as opposed to v2.1 & v2.2), this is primarily because it seems to be what others (aca-py & AFJ) are targeting and expect. similarly, V2.0 is what AIP2.0 lists as it's requirement: https://github.com/hyperledger/aries-rfcs/blob/main/concepts/0302-aries-interop-profile/README.md#base-requirements
The changes are virtually identical to #990 , other changes include:
AttachmentFormatSpecifier
to a common place