Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract primitives and remove Profile #1016

Merged
merged 13 commits into from
Oct 19, 2023
Merged

Conversation

bobozaur
Copy link
Contributor

This PR removes the Profile trait in favor of using independent components instead. Additionally, it aims to remove the shared usage of primitive components (making them depend on each other) and instead rely on function signatures to specifically ask for the components needed (without hidden implications that passing Anoncreds will also pass a Wallet instance).

Signed-off-by: Bogdan Mircea <[email protected]>
Signed-off-by: Bogdan Mircea <[email protected]>
Signed-off-by: Bogdan Mircea <[email protected]>
Signed-off-by: Bogdan Mircea <[email protected]>
Signed-off-by: Bogdan Mircea <[email protected]>
Signed-off-by: Bogdan Mircea <[email protected]>
Signed-off-by: Bogdan Mircea <[email protected]>
Signed-off-by: Bogdan Mircea <[email protected]>
@bobozaur bobozaur force-pushed the refactor/extract_primitives branch from 201afe1 to 3e9c893 Compare October 18, 2023 08:22
Signed-off-by: Bogdan Mircea <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2023

Codecov Report

Merging #1016 (b35b0b2) into main (b2e87eb) will increase coverage by 0.72%.
The diff coverage is 86.08%.

@@            Coverage Diff             @@
##             main    #1016      +/-   ##
==========================================
+ Coverage   35.97%   36.69%   +0.72%     
==========================================
  Files         372      369       -3     
  Lines       21745    21811      +66     
  Branches     4014     4011       -3     
==========================================
+ Hits         7822     8003     +181     
+ Misses      11763    11653     -110     
+ Partials     2160     2155       -5     
Flag Coverage Δ
unittests-aries-vcx 36.69% <86.08%> (+0.72%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
agency_client/src/messages/a2a_message.rs 0.00% <ø> (ø)
agency_client/src/messages/create_key.rs 0.00% <ø> (ø)
agency_client/src/messages/update_com_method.rs 0.00% <ø> (ø)
aries_vcx/src/common/anoncreds.rs 84.16% <100.00%> (+1.28%) ⬆️
aries_vcx/src/common/keys.rs 50.00% <100.00%> (ø)
...vcx/src/common/primitives/credential_definition.rs 61.31% <100.00%> (+2.36%) ⬆️
aries_vcx/src/common/proofs/prover/mod.rs 48.78% <100.00%> (+2.62%) ⬆️
aries_vcx/src/common/proofs/verifier/mod.rs 86.64% <100.00%> (+1.09%) ⬆️
aries_vcx/src/common/test_utils.rs 94.89% <100.00%> (+0.78%) ⬆️
aries_vcx/src/handlers/issuance/holder.rs 43.94% <100.00%> (+1.46%) ⬆️
... and 37 more

... and 1 file with indirect coverage changes

Signed-off-by: Bogdan Mircea <[email protected]>
Signed-off-by: Bogdan Mircea <[email protected]>
@bobozaur bobozaur self-assigned this Oct 18, 2023
@Patrik-Stas Patrik-Stas merged commit 3a5293a into main Oct 19, 2023
28 checks passed
@Patrik-Stas Patrik-Stas deleted the refactor/extract_primitives branch October 19, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants