Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uniffi holder API #1014

Merged
merged 8 commits into from
Oct 31, 2023
Merged

Add uniffi holder API #1014

merged 8 commits into from
Oct 31, 2023

Conversation

swaptr
Copy link
Contributor

@swaptr swaptr commented Oct 11, 2023

This PR adds support for uniffi holder API.

@swaptr swaptr requested a review from gmulhearn October 11, 2023 04:53
@swaptr swaptr self-assigned this Oct 11, 2023
@swaptr swaptr force-pushed the uniffi-holder branch 2 times, most recently from 71d9dd1 to 2e56921 Compare October 11, 2023 04:54
@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2023

Codecov Report

Merging #1014 (a144b75) into main (9846060) will decrease coverage by 0.07%.
Report is 3 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff            @@
##            main   #1014      +/-   ##
========================================
- Coverage   0.11%   0.05%   -0.07%     
========================================
  Files        383     383              
  Lines      21288   21288              
  Branches    3837    3837              
========================================
- Hits          25      12      -13     
- Misses     21258   21275      +17     
+ Partials       5       1       -4     
Flag Coverage Δ
unittests-aries-vcx 0.05% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

@swaptr swaptr force-pushed the uniffi-holder branch 13 times, most recently from b7b762e to b58b668 Compare October 23, 2023 01:34
@swaptr swaptr marked this pull request as ready for review October 23, 2023 04:11
@swaptr swaptr force-pushed the uniffi-holder branch 3 times, most recently from 3dd7ee3 to 48a3dbd Compare October 25, 2023 00:50
Signed-off-by: Swapnil Tripathi <[email protected]>
Signed-off-by: Swapnil Tripathi <[email protected]>
Signed-off-by: Swapnil Tripathi <[email protected]>
Signed-off-by: Swapnil Tripathi <[email protected]>
Signed-off-by: Swapnil Tripathi <[email protected]>
Signed-off-by: Swapnil Tripathi <[email protected]>
@swaptr swaptr force-pushed the uniffi-holder branch 2 times, most recently from a144b75 to 0fdfe19 Compare October 30, 2023 11:50
Signed-off-by: Swapnil Tripathi <[email protected]>
Copy link
Contributor

@gmulhearn gmulhearn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, lgtm

@gmulhearn gmulhearn merged commit c9ffebd into hyperledger:main Oct 31, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants