-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add uniffi holder API #1014
Merged
Merged
Add uniffi holder API #1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swaptr
force-pushed
the
uniffi-holder
branch
2 times, most recently
from
October 11, 2023 04:54
71d9dd1
to
2e56921
Compare
Codecov Report
@@ Coverage Diff @@
## main #1014 +/- ##
========================================
- Coverage 0.11% 0.05% -0.07%
========================================
Files 383 383
Lines 21288 21288
Branches 3837 3837
========================================
- Hits 25 12 -13
- Misses 21258 21275 +17
+ Partials 5 1 -4
Flags with carried forward coverage won't be shown. Click here to find out more. |
swaptr
force-pushed
the
uniffi-holder
branch
13 times, most recently
from
October 23, 2023 01:34
b7b762e
to
b58b668
Compare
gmulhearn
reviewed
Oct 23, 2023
swaptr
force-pushed
the
uniffi-holder
branch
3 times, most recently
from
October 25, 2023 00:50
3dd7ee3
to
48a3dbd
Compare
Signed-off-by: Swapnil Tripathi <[email protected]>
Signed-off-by: Swapnil Tripathi <[email protected]>
Signed-off-by: Swapnil Tripathi <[email protected]>
Signed-off-by: Swapnil Tripathi <[email protected]>
Signed-off-by: Swapnil Tripathi <[email protected]>
Signed-off-by: Swapnil Tripathi <[email protected]>
swaptr
force-pushed
the
uniffi-holder
branch
2 times, most recently
from
October 30, 2023 11:50
a144b75
to
0fdfe19
Compare
Signed-off-by: Swapnil Tripathi <[email protected]>
Signed-off-by: George Mulhearn <[email protected]>
gmulhearn
approved these changes
Oct 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for uniffi holder API.