Remove unused oob APIs, move code to libvcx_core (#1039)

* Remove unused oob APIs, move code to `libvcx_core` (#1039) Signed-off-by: Patrik Stas <[email protected]>
hyperledger · Nov 7, 2023 · 9bb6bf5 · 9bb6bf5
1 parent c046838
commit 9bb6bf5
Show file tree

Hide file tree

Showing 27 changed files with 644 additions and 962 deletions.
diff --git a/agents/node/vcxagent-core/src/services/service-out-of-band.js b/agents/node/vcxagent-core/src/services/service-out-of-band.js
@@ -1,4 +1,4 @@
-const { OutOfBandSender, OutOfBandReceiver } = require('@hyperledger/node-vcx-wrapper')
+const { OutOfBandSender, OutOfBandReceiver, Connection } = require('@hyperledger/node-vcx-wrapper')
 
 module.exports.createServiceOutOfBand = function createServiceOutOfBand ({ logger, saveConnection, loadConnection }) {
   function _createOobSender (message, label) {
@@ -21,9 +21,8 @@ module.exports.createServiceOutOfBand = function createServiceOutOfBand ({ logge
   }
 
   async function createConnectionFromOobMsg (connectionId, oobMsg) {
-    const oob = OutOfBandReceiver.createWithMessage(oobMsg)
-    const connection = await oob.buildConnection()
-    await connection.connect('{}')
+    const connection = await Connection.createWithInvite({ id: 'foo', invite: oobMsg })
+    await connection.connect()
     await saveConnection(connectionId, connection)
   }
 

diff --git a/agents/node/vcxagent-core/test/out-of-band.spec.js b/agents/node/vcxagent-core/test/out-of-band.spec.js
@@ -50,13 +50,6 @@ describe('test out of band communication', () => {
     expect(payloadAlice.content).toBe('Hello Alice')
   })
 
-  it('Alice reuses a connection already established by Faber', async () => {
-    const { alice, faber } = await createPairedAliceAndFaberViaOobMsg()
-    const msg = await faber.createOobMessageWithDid()
-    const reused = await alice.createOrReuseConnectionUsingOobMsg(msg)
-    expect(reused).toBe(true)
-  })
-
   it('Faber issues credential via OOB', async () => {
     try {
       const { alice, faber } = await createAliceAndFaber()

diff --git a/agents/node/vcxagent-core/test/utils/alice.js b/agents/node/vcxagent-core/test/utils/alice.js
@@ -73,23 +73,6 @@ module.exports.createAlice = async function createAlice (serviceEndpoint = 'http
     await vcxAgent.agentShutdownVcx()
   }
 
-  async function createOrReuseConnectionUsingOobMsg (oobMsg) {
-    logger.info('createOrReuseConnectionUsingOobMsg >> Alice going to create or reuse connection using oob message')
-    logger.debug(`createOrReuseConnectionUsingOobMsg >> oobMsg = ${oobMsg}`)
-    await vcxAgent.agentInitVcx()
-    let reused = false
-
-    if (await vcxAgent.serviceOutOfBand.connectionExists([connectionId], oobMsg)) {
-      await vcxAgent.serviceOutOfBand.reuseConnectionFromOobMsg(connectionId, oobMsg)
-      reused = true
-    } else {
-      await vcxAgent.serviceOutOfBand.createConnectionFromOobMsg(connectionId, oobMsg)
-    }
-
-    await vcxAgent.agentShutdownVcx()
-    return reused
-  }
-
   async function updateConnection (expectedNextState) {
     logger.info(`Alice is going to update connection, expecting new state of ${expectedNextState}`)
     await vcxAgent.agentInitVcx()
@@ -263,8 +246,6 @@ module.exports.createAlice = async function createAlice (serviceEndpoint = 'http
     createNonmediatedConnectionFromInvite,
     nonmediatedConnectionProcessResponse,
     createConnectionUsingOobMessage,
-    createNonmediatedConnectionUsingOobMessage,
-    createOrReuseConnectionUsingOobMsg,
     acceptOobCredentialOffer,
     updateConnection,
     handleMessage,

diff --git a/aries_vcx/src/handlers/issuance/mediated_holder.rs b/aries_vcx/src/handlers/issuance/mediated_holder.rs
diff --git a/aries_vcx/src/handlers/issuance/mediated_issuer.rs b/aries_vcx/src/handlers/issuance/mediated_issuer.rs
diff --git a/aries_vcx/src/handlers/issuance/mod.rs b/aries_vcx/src/handlers/issuance/mod.rs
@@ -1,4 +1,2 @@
 pub mod holder;
 pub mod issuer;
-pub mod mediated_holder;
-pub mod mediated_issuer;